Skip to content

ci: scope Hurl retries to readiness - #1538

Open
lovasoa wants to merge 1 commit into
mainfrom
codex/ci-scope-hurl-retries
Open

lovasoa wants to merge 1 commit into
mainfrom
codex/ci-scope-hurl-retries

Conversation

@lovasoa

@lovasoa lovasoa commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Retry only each suite's safe first request for startup readiness. Keep retries for delayed Tempo indexing on the telemetry queries.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T20:48:52.955587Z b5af1b2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b5af1b20b2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +65 to +66
--from-entry 1 \
--to-entry 1 \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Probe SQLPage before running the email suite

In the checked hurl CI job, the sending emails suite's first entry only sends a DELETE to Mailpit on port 8025, so this entry-limited readiness run can succeed while SQLPage on port 8080 is still starting. Compose explicitly does not wait for containers to become ready, and the subsequent full-suite invocation has no global retry, leaving its immediate SQLPage GET vulnerable to a startup-race failure. Make the first probe target SQLPage (moving the idempotent cleanup afterward), or retain a request-level retry for that GET.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant