Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5af1b20b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| --from-entry 1 \ | ||
| --to-entry 1 \ |
There was a problem hiding this comment.
Probe SQLPage before running the email suite
In the checked hurl CI job, the sending emails suite's first entry only sends a DELETE to Mailpit on port 8025, so this entry-limited readiness run can succeed while SQLPage on port 8080 is still starting. Compose explicitly does not wait for containers to become ready, and the subsequent full-suite invocation has no global retry, leaving its immediate SQLPage GET vulnerable to a startup-race failure. Make the first probe target SQLPage (moving the idempotent cleanup afterward), or retain a request-level retry for that GET.
Useful? React with 👍 / 👎.
Retry only each suite's safe first request for startup readiness. Keep retries for delayed Tempo indexing on the telemetry queries.