Repository navigation
Centralize variable lookup policies - #1535
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
francesco-cattoglio
pushed a commit
to francesco-cattoglio/SQLPage
that referenced
this pull request
Oct 13, 2026
…C harness (sqlpage#1529) * test(suite) :: share helpers, close pools deterministically, slim OIDC harness Integration tests leaked every request's AppState: actix-web recycles test-built HttpRequestInner allocations into a per-request pool that the test path never drains, pinning database pools until process exit. Pooled ODBC connections keep cached prepared statements alive, which deadlocks Oracle's client at process exit. Close every test pool (clearing statement caches first, since close() alone leaves checked-out connections behind) while the test runtime is still alive, including after panics. Consolidate the suite around shared helpers (read_body_string, supports_database, request builders, OIDC login/config builders, multipart/webhook request builders) and share one AppState per test where possible, cutting duplication across oidc/uploads/requests/ data_formats/errors/server_timing/cookies/core. Net negative LOC. * test: replace custom runtime with service-backed response helpers Give test requests an Actix service-owned pool so dropping the service releases application state. Centralize request setup with response_for, response_with, and helpers for custom requests and shared state, while keeping standard actix_web tests. Cover state release on success, errors, and unwinding. Validate with the full Rust suite, all-feature Clippy, formatting, and the SQLite ODBC prepared-statement test. * test: remove test-harness metatest * test: dispatch integration helpers through the production app Use create_app inside the shared request helper so existing concise test calls exercise production routes and middleware. Update the prefix redirect assertion to check the actual 308 response and preserved request path. * Centralize variable lookup policies (sqlpage#1535) * refactor: centralize variable lookup and enumeration * Reuse request and immutable-variable fixtures for lookup coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralize request-variable lookup and merged enumeration in a private view. GET values remain borrowed, SET values release their RefCell borrow before returning, and explicitly NULL SET values suppress request fallbacks. Merged enumeration streams through Serde with SET > POST > GET precedence.
The existing
$namelookup remains SET then GET, with the same POST deprecation warnings. Source-specificsqlpage.variablesbehavior and public Rust interfaces are unchanged.Reuse existing regression structures:
test_variables_functionand its SQL page with GET/POST array collisions, array lookups, missing and POST-only compatibility lookups, and a SET NULL phase. The same test checks merged and source-specific enumeration before SET, after SET, and after NULL assignment.run_sqlisolation fixture covering inherited parent variables, child mutation, and explicit NULL input without changing the parent scope.The variable-access unit test module shrinks from 93 lines to 44, and total PR additions decrease from 214 to 195. The consolidation changes tests only.
Validation:
cargo fmt --all, formatting check,cargo clippy --all-targets --all-features -- -D warnings, andcargo test --features odbc-staticpassed (236 unit and 89 integration tests with in-memory SQLite). Local fixture servers required running tests outside the network sandbox.