Refine startup exception handling implementation - #51144
Closed
vishalsinghji wants to merge 1 commit into
Closed
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
Member
|
@vishalsinghji thanks for the PR but we prefer doing such refactoring at our own pace. Going from that code to Set.of can be automatically applied by an IDE. Your commit has no sigh-off directive and fails the DCO check. Finally, please do not mix different things in the same PR. Removing the null check in SpringApplicationRunListeners look sensible so if you want to submit another PR with the DCO check working, I am happ to review that. |
snicoll
added
status: declined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR performs a few small code cleanups in the startup exception handling code.
Setcreation withSet.of(...).SpringApplicationRunListeners.ReflectionUtilsimport.These changes are purely refactorings and do not change the existing behaviour.