Skip to content

refactor: rename SplunkAOMetrics to SplunkAOEvaluators (HYBIM-949) - #198

Merged
shuningc merged 1 commit into
mainfrom
HYBIM-949-rename-splunk-aometrics-to-splunk-aoevaluators
Jul 31, 2026
Merged

refactor: rename SplunkAOMetrics to SplunkAOEvaluators (HYBIM-949)#198
shuningc merged 1 commit into
mainfrom
HYBIM-949-rename-splunk-aometrics-to-splunk-aoevaluators

Conversation

@shuningc

Copy link
Copy Markdown
Contributor

Summary
Renames the built-in scorer enum SplunkAOMetrics → SplunkAOEvaluators (HYBIM-949) to align with the evaluators domain terminology introduced in the HYBIM-730 rename.

This is a hard cut-over: no backward-compatibility alias for SplunkAOMetrics.

Changes
Rename enum class in src/splunk_ao/schema/metrics.py
Update public export in src/splunk_ao/init.py
Update type hints and usages in SDK modules (agent_stream, agent_streams, evaluator, experiment, experiments, types, utils/metrics)
Update tests, examples, migration-tool docs, and domain-rename doc examples

Align the built-in scorer enum name with the evaluators domain terminology across the SDK, tests, examples, and migration docs.

Co-authored-by: Cursor <cursoragent@cursor.com>
@shuningc
shuningc marked this pull request as ready for review July 31, 2026 16:29

@fercor-cisco fercor-cisco left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 This review was generated by the Astra agent (claude-opus-4-8). It may contain mistakes.

Verdict: approve — Complete, consistent mechanical rename of SplunkAOMetrics→SplunkAOEvaluators; no stale references remain and tests/exports updated.

Follow-ups

Suggested follow-up work that could be tracked as Jira tickets:

  • tests/schemas/test_metrics.py:18-33: Test function names still read test_galileo_metrics_* despite the enum now being SplunkAOEvaluators and the Galileo prefix having been dropped in prior renames. Renaming these to test_evaluators_* would keep test naming aligned with the domain terminology. Non-blocking, cosmetic.
  • src/splunk_ao/schema/metrics.py:15-15: The SplunkAOEvaluators docstring still says 'Built-in Splunk AO metric scorers.' Consider updating the wording to 'evaluators' to match the new domain terminology. Non-blocking.

@fercor-cisco

Copy link
Copy Markdown
Collaborator

Filed follow-up stories under epic HYBIM-697 for the cosmetic items deferred from this rename:

  • HYBIM-955 — Rename test_galileo_metrics_* tests to test_evaluators_* (tests/schemas/test_metrics.py:18-33).
  • HYBIM-956 — Update the SplunkAOEvaluators docstring to say "evaluators" instead of "metric scorers" (src/splunk_ao/schema/metrics.py:15).

@shuningc
shuningc merged commit d4b0d78 into main Jul 31, 2026
13 checks passed
@shuningc
shuningc deleted the HYBIM-949-rename-splunk-aometrics-to-splunk-aoevaluators branch July 31, 2026 18:31
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants