refactor: rename SplunkAOMetrics to SplunkAOEvaluators (HYBIM-949) - #198
Merged
shuningc merged 1 commit intoJul 31, 2026
Merged
Conversation
Align the built-in scorer enum name with the evaluators domain terminology across the SDK, tests, examples, and migration docs. Co-authored-by: Cursor <cursoragent@cursor.com>
shuningc
marked this pull request as ready for review
July 31, 2026 16:29
fercor-cisco
left a comment
Collaborator
There was a problem hiding this comment.
🤖 This review was generated by the Astra agent (claude-opus-4-8). It may contain mistakes.
Verdict: approve — Complete, consistent mechanical rename of SplunkAOMetrics→SplunkAOEvaluators; no stale references remain and tests/exports updated.
Follow-ups
Suggested follow-up work that could be tracked as Jira tickets:
tests/schemas/test_metrics.py:18-33: Test function names still read test_galileo_metrics_* despite the enum now being SplunkAOEvaluators and the Galileo prefix having been dropped in prior renames. Renaming these to test_evaluators_* would keep test naming aligned with the domain terminology. Non-blocking, cosmetic.src/splunk_ao/schema/metrics.py:15-15: The SplunkAOEvaluators docstring still says 'Built-in Splunk AO metric scorers.' Consider updating the wording to 'evaluators' to match the new domain terminology. Non-blocking.
Collaborator
|
Filed follow-up stories under epic HYBIM-697 for the cosmetic items deferred from this rename: |
fercor-cisco
approved these changes
Jul 31, 2026
shuningc
deleted the
HYBIM-949-rename-splunk-aometrics-to-splunk-aoevaluators
branch
July 31, 2026 18:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the built-in scorer enum SplunkAOMetrics → SplunkAOEvaluators (HYBIM-949) to align with the evaluators domain terminology introduced in the HYBIM-730 rename.
This is a hard cut-over: no backward-compatibility alias for SplunkAOMetrics.
Changes
Rename enum class in src/splunk_ao/schema/metrics.py
Update public export in src/splunk_ao/init.py
Update type hints and usages in SDK modules (agent_stream, agent_streams, evaluator, experiment, experiments, types, utils/metrics)
Update tests, examples, migration-tool docs, and domain-rename doc examples