Fix TOOLS_JAVA_VERSION export in Dockerfile

[bact]

• In Dockerfile, env vars in one RUN didn't last to another RUN.
  So in our case, TOOLS_JAVA_VERSION is lost and breaks the @@VERSION@@ substitution for the scripts/tools-java-wrapper.sh -- producing tools-java--jar-with-dependencies.jar (missing version, double dash), causing error.
• Removes no-op source=$PWD on the bind mount.
  $PWD is not a recognized variable in Dockerfile, always empty.
  (No change in behavior, as default is the build context root. Just a cleanup to avoid confusion)

To fix #295

[bact]

@kzantow please help verify at your convenience. thank you.

[kzantow]

Thanks @bact -- I can confirm the Dockerfile built locally works for me:

% docker build -t tools-java-fix .
...
% docker run tools-java-fix  
Usage: java -jar spdx-tools-jar-with-dependencies.jar <function> <parameters> 
function                 parameter                         example 
------------------------------------------------------------------------------------------------------------------- 
Convert         inputFile outputFile [fromType] [toType]   Examples/SPDXTagExample.tag TagToSpreadsheet.xls 
SPDXViewer      inputFile                                  TestFiles/SPDXRdfExample.rdf 
Verify          inputFile [type]                           TestFiles/SPDXRdfExample.rdf 
CompareDocs     output.xlsx doc1 doc2 ... docN 
GenerateVerificationCode sourceDirectory
Version
MatchingStandardLicenses licenseTextFile

It looks like the version was removed from the jar, which seems like a simple fix but I'm not sure if there's a way to confirm the result of the workflow

[bact]

It looks like the version was removed from the jar, which seems like a simple fix but I'm not sure if there's a way to confirm the result of the workflow

If you mean the "spdx-tools-jar-with-dependencies.jar" in the usage, it is hard-coded here:

tools-java/src/main/java/org/spdx/tools/Main.java

Line 64 in 062c9c0

System.out.println("Usage: java -jar spdx-tools-jar-with-dependencies.jar <function> <parameters> \n"

To see if the jar is properly named with expected version number, you can try:

docker run --rm --entrypoint sh tools-java-fix -c 'ls /usr/lib/java/spdx/*.jar' 

To see if the version number is properly substituted in the tools-java wrapper:

docker run --rm --entrypoint sh tools-java-fix -c 'cat /usr/bin/tools-java'

These are checks that included in the smoke test, proposed in this PR: #298 -- should help prevent this issue in the future.