Add SpotBugs analysis check#434
Draft
bact wants to merge 2 commits into
Draft
Conversation
Also replace findbugs-maven-plugin with spotbugs-maven-plugin for reporting. Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Collaborator
Author
|
Failed as expected.
https://github.com/spdx/Spdx-Java-Library/actions/runs/29547366964/job/87782469020?pr=434#step:7:20 |
bact
marked this pull request as draft
July 17, 2026 01:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
spotbugsjob to thebuild.ymlworkflow:effort=Max,threshold=High) (SpotBugs is a fork of FindBugs)In
pom.xml, replaces the unmaintainedfindbugs-maven-pluginreporting entry withspotbugs-maven-pluginChoose threshold=High at this pointm as Medium will report too many errors. We can change this later.
This PR will failed until we fix all bugs reported by SpotBugs (currently 4 of them).
To resolve #210