Skip to content

Add SpotBugs analysis check#434

Draft
bact wants to merge 2 commits into
spdx:masterfrom
bact:spotbugs
Draft

Add SpotBugs analysis check#434
bact wants to merge 2 commits into
spdx:masterfrom
bact:spotbugs

Conversation

@bact

@bact bact commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Adds a spotbugs job to the build.yml workflow:

  • Runs SpotBugs analysis (effort=Max, threshold=High) (SpotBugs is a fork of FindBugs)
  • Fails the job if any bug is found

In pom.xml, replaces the unmaintained findbugs-maven-plugin reporting entry with spotbugs-maven-plugin

Choose threshold=High at this pointm as Medium will report too many errors. We can change this later.

This PR will failed until we fix all bugs reported by SpotBugs (currently 4 of them).

To resolve #210

Also replace findbugs-maven-plugin with spotbugs-maven-plugin for reporting.

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact added the ci Dev workflow and repo management label Jul 17, 2026
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@bact

bact commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator Author

Failed as expected.

Error: SpotBugs found 4 bug(s). See the Checks/Security tab for annotated details.

https://github.com/spdx/Spdx-Java-Library/actions/runs/29547366964/job/87782469020?pr=434#step:7:20

@bact
bact marked this pull request as draft July 17, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Dev workflow and repo management

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update CI to flag any new quality issues

2 participants