chore: update vendored Sourcegraph lib#1328
Merged
Merged
Conversation
Vendor github.com/sourcegraph/sourcegraph/lib at bdc2f4bb8b59f78f4fa8868b2690b673b41948d4 and restore src-cli compatibility for APIs still used locally. Test Plan: go test ./... Amp-Thread-ID: https://ampcode.com/threads/T-019e8206-7c7d-76cb-9b08-b6e0df454e15 Co-authored-by: Amp <amp@ampcode.com>
burmudar
approved these changes
Jun 1, 2026
keegancsmith
reviewed
Jun 1, 2026
| ) | ||
|
|
||
| // See: https://github.com/ghodss/yaml/pull/65 | ||
| replace github.com/ghodss/yaml => github.com/sourcegraph/yaml v1.0.1-0.20200714132230-56936252f152 |
Member
There was a problem hiding this comment.
and regenerated the nested lib/go.mod contents
@bahrmichael Looks like you nuked it? I'll send a PR
Contributor
Author
There was a problem hiding this comment.
That was the result of running the vendor lib script. We may need to fix that script if this change is not intentional.
Contributor
Author
There was a problem hiding this comment.
Looking at the vendor script, it looks like the go mod tidy at the end may have a silent failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR is fully Amp-generated after I ran dev/vendor-lib.sh. See https://ampcode.com/threads/T-019e8206-7c7d-76cb-9b08-b6e0df454e15.
This updates the vendored
github.com/sourcegraph/sourcegraph/libsnapshot so src-cli stays current with the shared library code it depends on.I ran
./dev/vendor-lib.shfrom this repository while../sourcegraphwas onmainatbdc2f4bb8b59f78f4fa8868b2690b673b41948d4with a clean worktree. The script refreshed the selected packages underlib/, rewrotelib/README.mdwith the source commit/date, and regenerated the nestedlib/go.modcontents.After vendoring,
go test ./...exposed a few src-cli compatibility gaps from APIs/packages that are still used locally but no longer discovered or preserved by the raw vendoring step. I restored the still-needed validation/docgen/helper packages and kept small compatibility shims for output status bars, progress options, styles, and code-intel request logging. I also re-added thestep.filestarget-path validation that src-cli tests still expect.Test Plan
go test ./...