Skip to content
This repository was archived by the owner on Jul 26, 2020. It is now read-only.
This repository was archived by the owner on Jul 26, 2020. It is now read-only.

Consider making AprilTagDetector use a new working area for each image #17

Open

Description

@PeterJCLaw

Currently we create one upfront and then re-use it. This means that if the same detector is used from multiple threads, weird things could happen.
There doesn't appear to be a noticeable performance benefit to creating this working space upfront (tested on my desktop, not a pi), so I'm inclined to suggest that we shouldn't bother doing so.

I'm not sure whether the detector logic itself is thread-safe, so if it's not then we should probably look at adding locks instead of bothering with this approach.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions