Repository navigation
Rounder ( [U+0028] and ) [U+0029] #424
Description
This continues the discussion from issue #120.
The current parentheses, ( [U+0028] and ) [U+0029] seem a little bit too straight, and too far apart when placed next to each other, for example in fn_call(). I'm working on updated versions to address these issues.
Here are some screenshots to show my changes in a bunch of different contexts. First the current parentheses:
And my modified versions:
I still have to work on the bold, italic, and bold italic, but I thought I'd share what I've got so far.
EDIT: The new parentheses should also look less out of place next to the new square brackets.
Activity
jdw1996 commentedon Mar 25, 2018
I created the other styles as well; in case anyone wants to build Hack with these variants for testing, I'll attach the
*.gliffiles below.I'm also going to start using a custom build with these glyphs in my day-to-day work, to hopefully identify any possible issues with them.
rounder-parens.zip
chrissimpkins commentedon Mar 26, 2018
Looks great Joseph! I like the design. Thanks for doing this work on them. I am putting this on for v4.001 work along with your
<and>proposal.Would it be helpful to commit both sets of glyphs to the alt-hack repo for now so that others can build them and then we can incorporate after we have done further testing / confirmed that these are the designs that we want as defaults? If so, feel free to submit PR's on that repo and we will remove the alternate glyphs there if they become defaults.
jdw1996 commentedon Mar 26, 2018
That's a great idea. I will open the PRs on alt-hack tonight.
chrissimpkins commentedon Mar 26, 2018
I suggest that we use alt-hack as a testing ground. That is part of the reason that it is there. Applies to anyone who would like to contribute new glyph designs for existing glyphs in the sets. Please submit to alt-hack immediately when designs are available and they will be incorporated in the alternate repo for anyone to build immediately. There is not a rigorous review process there and we would like to support numerous options whether or not they wind up as defaults here. This allows us to support new designs rapidly AND properly vet new defaults before they become defaults. That takes a bit of time and I don't want to slow down development out there :) Keep them coming!
We can open new glyph design alternate issue reports on this repo under the Alternate Design label so that those with an interest in building/testing/providing feedback can do so.
jdw1996 commentedon Mar 27, 2018
The corresponding pull request on the alt-hack repository can be found here:
source-foundry/alt-hack#38
chrissimpkins commentedon Mar 27, 2018
Merged! Thanks Joseph!
chrissimpkins commentedon May 18, 2018
I've pushed the v4.000 release back a bit to address some issues in the new build tooling. Let's plan to put this on for v4.000 release work. I modified the milestone.
jdw1996 commentedon May 18, 2018
Sounds good, just let me know if there's anything you need me to do.
EDIT: I just realized I haven't made a PR into this repo yet. Should I do that now?
chrissimpkins commentedon May 18, 2018
Thanks Joseph. Hopefully nothing. I will post some additional source images here once I build sets that include these changes. The images that you posted look really good. I like the changes. Will be taking a look at idioms that use the parentheses across a number of different source types and would like to see the renders. Will post here when fonts are built with these changes in case anyone else would like to view and weigh in with their own source/terminal/other text use cases.
chrissimpkins commentedon May 28, 2018
@jdw1996 do you mind submitting your two open issue reports with alternate glyph designs as pull requests? Let's get you in the git log as the author of these changes.
chrissimpkins commentedon May 28, 2018
I can do this if there is no time for it on your end but would like to record you as the author of the commits
jdw1996 commentedon May 28, 2018
I don't mind at all. I will open them when I get home tonight.
chrissimpkins commentedon Jun 11, 2018
#433 with these changes was merged to dev branch and these changes will be included in the v4.000 release