Skip to content

Update solvers in our example projects#662

Open
daniel-raffler wants to merge 14 commits into
masterfrom
update-maven-example
Open

Update solvers in our example projects#662
daniel-raffler wants to merge 14 commits into
masterfrom
update-maven-example

Conversation

@daniel-raffler

@daniel-raffler daniel-raffler commented May 22, 2026

Copy link
Copy Markdown
Contributor

Hello,

this PR updates the version numbers in our Maven example to the JavaSMT 6.0.0-148-gba08f432a release. There is a newer version of JavaSMT in the Maven repository, however, Yices2 is broken on that one, so this is the last version that works

The PR now also updates the web version of the Maven example, and our two Gradle project templates, which have been unmaintained for several years

@daniel-raffler
daniel-raffler marked this pull request as draft May 22, 2026 12:16
@daniel-raffler daniel-raffler changed the title Update version numbers in the Maven example Update solvers in our example projects May 25, 2026
@daniel-raffler
daniel-raffler marked this pull request as ready for review May 25, 2026 15:05

@baierd baierd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you!

Did you run/test the examples in a fresh checkout?

Comment thread doc/Example-Gradle-Project-Kotlin/build.gradle.kts
@daniel-raffler

Copy link
Copy Markdown
Contributor Author

Nice work! Thank you!

Thanks!

Did you run/test the examples in a fresh checkout?

Yes, I worked on all of these as separate projects and then simply copied the files back into the JavaSMT folder. So they are tested and should be working. However, it might still be better to wait until we have the CI set up for these example projects before merging anything

@baierd

baierd commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

@daniel-raffler are there any changes to the behavior of the projects or their tests due to the changes in this PR?

@daniel-raffler

Copy link
Copy Markdown
Contributor Author

@daniel-raffler are there any changes to the behavior of the projects or their tests due to the changes in this PR?

No, nothing major. The Gradle and Kotlin were quite outdated and were missing tests for several of the new solvers. I tried to make them more aligned with what we're doing in the Maven project, which was much more up to date, and they're now also using parametrized tests for all the solvers. As a side-effect this means that the test is now always for Sudoku.BooleanBasedSudokuSolver when it used to be Sudoku.IntegerBasedSudokuSolver before for solvers that support integers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants