fix: handle URL changes before hydration starts - #2317
Open
brenelz wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: c3c46b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2313.
If the browser URL changes before the client router initializes, hydration currently tries to match the new route against the previous route’s server-rendered HTML. This can throw a hydration mismatch and leave the app blank. A query-only change can also silently reuse stale server data.
data-start-url.mount().The guard handles the early URL change in the issue’s reproduction. A real link navigation while the initial route module is still loading is also covered by a control test. This works with the current Solid dependencies.
Regression coverage
The tests pin the timing by holding the client entry request, rather than sweeping machine-dependent delays:
They assert interactive content, a single layout and page, and no browser errors. The path and query cases failed before the fix; the hash-only control passed.
Verification
pnpm --filter @solidjs/start test:ci: 114 tests passed.pnpm --filter @solidjs/start typecheckpnpm --filter @solidjs/start validate-importspnpm --filter @solidjs/start buildpnpm --filter tests buildgit diff --checkpassed.