Replace the published engines field with devEngines in the JS client - #87
Merged
Conversation
This PR removes the engines field from the published JS client manifest and declares the Node 24 dev-tooling floor via devEngines.runtime instead. engines constrains consumers rather than contributors - Yarn Classic hard-fails installing the client into any project running Node < 24 - while the client's actual runtime floor is simply inherited from @solana/kit. devEngines only applies to this repository's own development and is enforced by npm ≥ 10.9. It also bumps the pinned pnpm from 9.1.0 to 10.15.1 to align with the rest of the fleet, with lockfiles rebuilt from scratch using the pinned version.
Restores the root manifest and both lockfiles to main. The from-scratch root lockfile rebuild that accompanied the pnpm 10 bump re-resolved the Codama renderers, whose newer patch versions change the generated Rust client output and fail the client-generation check. The pnpm alignment and the renderer bump will each get their own PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
enginesfield from the published JS client manifest and declares the Node 24 dev-tooling floor viadevEngines.runtimeinstead.enginesconstrains consumers rather than contributors — Yarn Classic hard-fails installing the client into any project running Node < 24 (see solana-program/token#176) — while the client's actual runtime floor is simply inherited from@solana/kit.devEnginesonly applies to this repository's own development and is enforced by npm ≥ 10.9.