Skip to content

fix Sui mcms reader - #1135

Open
FelixFan1992 wants to merge 1 commit into
mainfrom
fix-sui
Open

fix Sui mcms reader#1135
FelixFan1992 wants to merge 1 commit into
mainfrom
fix-sui

Conversation

@FelixFan1992

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings July 28, 2026 21:50
@FelixFan1992
FelixFan1992 requested a review from a team as a code owner July 28, 2026 21:50
@changeset-bot

changeset-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8fb2f63

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown

👋 FelixFan1992, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support in the experimental analyzer for surfacing Sui “upgraded package” routing metadata (stored in Sui MCMS additional fields) so decoded calls can show both the MCMS identity package (tx.To) and the actual execution package target.

Changes:

  • Introduces Sui package-routing helpers to emit execution package ID(s) plus optional execution contract type/version from the address book.
  • Updates AnalyzeSuiTransaction to include routing metadata in decoded call inputs (including for MCMS wrapper calls and decode failure fallbacks).
  • Adds unit tests covering both the routing helper output and end-to-end behavior via AnalyzeSuiTransaction.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
experimental/analyzer/sui_package_routing.go New helper logic to derive and prepend Sui upgraded-package routing inputs (execution package + optional contract metadata).
experimental/analyzer/sui_package_routing_test.go Adds tests validating routing input construction and integration with AnalyzeSuiTransaction.
experimental/analyzer/sui_analyzer.go Prepends routing inputs to decoded inputs and includes them in “mcms module” and error-return decoded calls.
experimental/analyzer/decoded_call.go Refactors contract-info lookup into a reusable helper to support address-based lookups (identity vs execution package).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants