Re-enable TCK Tests and implement spec features - #2392
Draft
phillip-kruger wants to merge 2 commits into
Draft
Conversation
phillip-kruger
changed the title
phillip-kruger
force-pushed
the
dust-off
branch
from
February 3, 2026 02:34
7fe2ccc to
4809a02
Compare
phillip-kruger
force-pushed
the
dust-off
branch
2 times, most recently
from
June 30, 2026 01:05
6fa5eda to
6f11082
Compare
phillip-kruger
changed the title
phillip-kruger
force-pushed
the
dust-off
branch
2 times, most recently
from
July 2, 2026 00:52
b6c4080 to
9dfda80
Compare
Bump microprofile-graphql to 2.1-SNAPSHOT and re-enable the TCK tests that were previously skipped, removing all override files that are no longer needed. Implement two features added to the spec: - @Source.value() support for custom field names (preferred over the deprecated @Source.name()) - JSON default values rendered as AST literals in the schema via a new DefaultValueAstHelper Migrate @subscription from the SmallRye-specific annotation to org.eclipse.microprofile.graphql.Subscription with backward compatibility for the old annotation across server and client. Add Flow.Publisher support alongside org.reactivestreams.Publisher for subscription methods. Also fix the micrometer property name typo and remove stale commented-out client dependency block from the parent pom. Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
Replace all jakarta.json (JSON-P) usage with Jackson across the server API, implementation, servlet, CDI, and test modules. Key changes: - Context API returns ObjectNode/ArrayNode instead of JsonObject/JsonArray - ErrorExtensionProvider returns JsonNode instead of JsonValue - ExecutionService accepts ObjectNode instead of JsonObject - WebSocket handlers and ExecutionServlet parse/build with Jackson - Remove bridge methods (getExecutionResultAsJsonPObject, etc.) - Delete JsonProviderHolder - Remove jakarta.json-api dependency from server modules - Update TestInterceptor to use Jackson (requires MP GraphQL TCK PR microprofile/microprofile-graphql#598) The only remaining jakarta.json import is CurrencyAdapter.java in schema-builder tests (JSON-B adapter boundary).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump microprofile-graphql to 2.1-SNAPSHOT and re-enable the TCK tests that were previously skipped, removing all override files that are no longer needed.
Implement two features added to the spec:
Migrate @subscription from the SmallRye-specific annotation to org.eclipse.microprofile.graphql.Subscription with backward compatibility for the old annotation across server and client.
Add Flow.Publisher support alongside org.reactivestreams.Publisher for subscription methods.
Also fix the micrometer property name typo and remove stale commented-out client dependency block from the parent pom.