Skip to content

fix(web-api): type Slack Lists message fieldFix Slack Lists message field response type responses#2621

Closed
cxdmnls wants to merge 4 commits into
slackapi:mainfrom
cxdmnls:fix-slack-lists-message-field-type
Closed

fix(web-api): type Slack Lists message fieldFix Slack Lists message field response type responses#2621
cxdmnls wants to merge 4 commits into
slackapi:mainfrom
cxdmnls:fix-slack-lists-message-field-type

Conversation

@cxdmnls

@cxdmnls cxdmnls commented Jun 8, 2026

Copy link
Copy Markdown

Summary

Fixes #2598.

This PR updates the Slack Lists FieldMessage.message type to match the API response shape. The field can now be either a single message object or an array of message objects. A focused tsd type test was added to cover both response shapes.

Requirements

@cxdmnls cxdmnls requested a review from a team as a code owner June 8, 2026 12:02
@salesforce-cla

salesforce-cla Bot commented Jun 8, 2026

Copy link
Copy Markdown

Thanks for the contribution! Unfortunately we can't verify the commit author(s): 常侯鑫 <3***@q***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

@changeset-bot

changeset-bot Bot commented Jun 8, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1d984cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hey @cxdmnls! Thanks for sending this in!

I'm going to close it to prefer approach more aligned with #2599 or codegen from an adjacent project. Super appreciate the PR 🎁

Comment on lines -65 to +73
message: string[];
message: SlackListsItemMessage | SlackListsItemMessage[];

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛 issue: This is breaking to the API input with an internal error shown in #2640

@zimeg zimeg closed this Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SlackListsItem FieldMessage.message type does not match API response shape

2 participants