fix: propagate Socket Mode retry_attempt and retry_reason to BoltRequest headers#1498
Merged
WilliamBergamin merged 1 commit intoMay 13, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1498 +/- ##
==========================================
+ Coverage 91.32% 91.34% +0.02%
==========================================
Files 228 228
Lines 7262 7271 +9
==========================================
+ Hits 6632 6642 +10
+ Misses 630 629 -1 ☔ View full report in Codecov by Sentry. |
WilliamBergamin
approved these changes
May 13, 2026
Contributor
WilliamBergamin
left a comment
WilliamBergamin
left a comment
There was a problem hiding this comment.
Nice 💯 this does solve the issue
I'll merge this PR and follow up with additional unit tests that follow current patterns
| from slack_bolt.response import BoltResponse | ||
|
|
||
|
|
||
| def build_retry_headers(req: SocketModeRequest) -> Optional[Dict[str, Union[str, Sequence[str]]]]: |
Contributor
There was a problem hiding this comment.
Lets name this build_headers 🤔
Suggested change
| def build_retry_headers(req: SocketModeRequest) -> Optional[Dict[str, Union[str, Sequence[str]]]]: | |
| def build_headers(req: SocketModeRequest) -> Optional[Dict[str, Union[str, Sequence[str]]]]: |
WilliamBergamin
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In Socket Mode,
SocketModeRequest.retry_attemptandSocketModeRequest.retry_reasonwere dropped when building the Bolt request, so middleware and listeners could not detect Events API retries the way they can in HTTP mode. This synthesizes thex-slack-retry-num/x-slack-retry-reasonheaders from the envelope so existing retry detection logic works unchanged under Socket Mode. Closes #1484.Testing
Run
python -m pytest tests/adapter_tests/socket_mode/test_internals.py tests/scenario_tests/test_events_socket_mode.py.Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.Note: I have not yet signed the Salesforce CLA; happy to do so if this is something you would like to accept.