Mkl#288
Merged
Merged
Conversation
gabordozsa
approved these changes
May 29, 2026
gabordozsa
left a comment
gabordozsa
left a comment
There was a problem hiding this comment.
Looks very good! I have only minor comments.
c-kruse
approved these changes
May 29, 2026
| * priority - Uses the first routing key in list that is available for traffic. If the connector becomes unavailable, the listener matches with the next available routing key in list. | ||
| * weighted - Uses the routing keys in proportion to the assigned weights. For example, if `backend1` is assigned 25 and `backend2` is assigned 75, then only a quarter of the TCP connections are directed to `backend1`. | ||
|
|
||
| Multi-key listeners provide predictable traffic distribution from the client side and are **not influenced by link costs**. |
There was a problem hiding this comment.
Could be too much detail, but as I understand it link costs do not affect the routing key a connection is routed to. Normal link cost + least connected rules apply within that routing key same as a Listener.
Member
Author
There was a problem hiding this comment.
I think it prob is too much detail for this location, but needs explaining somewhere, how about the following text:
https://gist.github.com/pwright/95fb7ce069201fee6b747decaa5fed2b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is large cos i regenerated refdog, so here are the rendered new bits: