🎨 Palette: Add loading states to authentication forms - #176
singhaditya21 wants to merge 1 commit into
Conversation
… the auth forms for you. Here is a breakdown of the updates I made: - I set up the code to target the active button during form events. - I added inline styles (opacity, disabled state, not-allowed cursor) during async login/register requests. - I ensured the original button content and styles are safely reverted inside a `try/finally` block. Co-authored-by: singhaditya21 <53948039+singhaditya21@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closing as a duplicate. An automated agent opened 144 near-identical PRs adding loading states to the web-demo auth buttons, one per day. Closing the batch to clear the review queue; the branch is retained if this change is still wanted, and the work is small enough to redo in a single focused PR. See ROADMAP.md for the current backlog. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
💡 What:
Added visual loading states to the authentication form submit buttons (Login and Register). The buttons now become disabled, reduce opacity, change the cursor to "not-allowed", and display "⏳ Loading..." during API requests.
🎯 Why:
Previously, submitting these forms provided no immediate visual feedback to the user on the button itself. This could lead to user frustration or multiple accidental submissions if the network request is slow.
📸 Before/After:
♿ Accessibility:
disabledduring submission, which prevents screen readers from announcing it as interactable and removes it from the active tab order while processing.e.submitterensures we dynamically modify the exact element the user activated.PR created automatically by Jules for task 1080634200726528147 started by @singhaditya21