Skip to content

[ele] don't remove tier immediately on the spell that removes sk #11631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HawkCorrigan merged 2 commits into from
Jul 24, 2026
+4 −4
Merged

[ele] don't remove tier immediately on the spell that removes sk #11631

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d089530
Don't decrement tier when generating it
HawkCorrigan Jul 24, 2026
7e77be5
Don't remove tier when generating it
HawkCorrigan Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions engine/class_modules/sc_shaman.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6568,6 +6568,8 @@ struct chain_lightning_t : public chained_base_t
{
chained_base_t::execute();

p()->buff.mid2_ele_4pc_builder->decrement();

if ( is_variant( spell_variant::NORMAL ) && p()->specialization() == SHAMAN_ELEMENTAL )
{
if ( p()->talent.routine_communication.ok() && p()->rng_obj.routine_communication->trigger() )
Expand Down Expand Up @@ -6612,8 +6614,6 @@ struct chain_lightning_t : public chained_base_t
p()->trigger_thunderstrike_ward( execute_state );

proc_lightning_rod();

p()->buff.mid2_ele_4pc_builder->decrement();
}

void impact( action_state_t* state ) override
Expand Down Expand Up @@ -7352,15 +7352,15 @@ struct lightning_bolt_t : public shaman_spell_t
void execute() override
{
shaman_spell_t::execute();

p()->buff.mid2_ele_4pc_builder->decrement();
if ( is_variant( spell_variant::NORMAL ) && p()->specialization() == SHAMAN_ELEMENTAL )
{
if ( !p()->sk_during_cast )
{
p()->buff.stormkeeper->decrement();
}
p()->sk_during_cast = false;
p()->buff.mid2_ele_4pc_builder->decrement();


if ( p()->talent.routine_communication.ok() && p()->rng_obj.routine_communication->trigger() )
{
Expand Down
Loading