Skip to content

Fix LT-22600: Show Hermit Crab rule statistics#449

Draft
jtmaxwell3 wants to merge 6 commits into
masterfrom
LT-22600
Draft

Fix LT-22600: Show Hermit Crab rule statistics#449
jtmaxwell3 wants to merge 6 commits into
masterfrom
LT-22600

Conversation

@jtmaxwell3

@jtmaxwell3 jtmaxwell3 commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Adds code to instrument rule applications by creating an InstrumentedRule class for the rules that should be instrumented. Changes the code for creating rule classes to record data needed for instrumentation. Changes the Apply functions to collect statistics.


This change is Reviewable

@jtmaxwell3 jtmaxwell3 marked this pull request as draft July 2, 2026 21:33
@codecov-commenter

codecov-commenter commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 74.28571% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.31%. Comparing base (c271990) to head (811e32f).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/SIL.Machine.Morphology.HermitCrab/Morpher.cs 10.00% 18 Missing ⚠️
src/SIL.Machine/Rules/InstrumentedRule.cs 63.41% 15 Missing ⚠️
src/SIL.Machine/Rules/ParallelRuleBatch.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master     #449    +/-   ##
========================================
  Coverage   73.31%   73.31%            
========================================
  Files         443      444     +1     
  Lines       37190    37324   +134     
  Branches     5110     5118     +8     
========================================
+ Hits        27264    27363    +99     
- Misses       8800     8835    +35     
  Partials     1126     1126            

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants