Update scroll-group hook stubs for the new sourceProjectId tuple element#162
Update scroll-group hook stubs for the new sourceProjectId tuple element#162alex-rawlings-yyc wants to merge 1 commit into
Conversation
paranext-core added a trailing sourceProjectId element to UseWebViewScrollGroupScrRefHook; alias ScrollGroupTuple from the hook's return type and pad the stubs so tests type-check against it.
|
Warning Review limit reached
Next review available in: 38 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
paranext-coreadded a trailingsourceProjectIdelement toUseWebViewScrollGroupScrRefHook, so it now returns a 5-element tuple:Our test stubs still constructed the old 4-element tuple, so
tsc --noEmit(via
npm run lint) fails against current@papi/corewithSource has 4 element(s) but target requires 5.This updates the stubs to match. No production code changes —
InterlinearNavContextdestructures only the first four elements, so it wasalready compatible; only the test doubles that build the tuple needed the
extra element.
Changes
test-helpers.ts:ScrollGroupTupleis now aliased fromReturnType<UseWebViewScrollGroupScrRefHook>instead of restating the tupleshape, so it tracks the platform hook's arity and can't drift again;
makeScrollGroupHookgained asourceProjectIdparam defaulting toundefined.(
Interlinearizer,InterlinearizerLoader,interlinearizer.web-view) nowuse the shared
ScrollGroupTuplealias plus a trailingundefinedvalue.InterlinearNavContext.test.tsx: one inline stub got its fifth element.Why separate from the feature work
mainitself fails to type-check against the current PAPI types, independent ofany feature branch — this restores
mainto green on its own.Verification
npm run lint(eslint + stylelint +tsc --noEmit) — passnpm test— 1284 passingnpm run test:coverage— 100%`
This change is