Fix intermittent access violation in RenderBenchmark tests#919
Merged
Conversation
Add [Apartment(ApartmentState.STA)] to RenderTimingSuiteTests and RenderVerifyTests. The Views COM objects (VwGraphicsWin32Class, _VwRootBoxClass) require STA threading; without the attribute, NUnit runs these tests on an MTA thread, causing intermittent access violations during RootBox.Layout in CI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mark-sil
reviewed
Jun 2, 2026
Contributor
mark-sil
left a comment
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on jasonleenaylor).
mark-sil
approved these changes
Jun 2, 2026
Contributor
mark-sil
left a comment
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil reviewed 2 files and all commit messages.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[Apartment(ApartmentState.STA)]toRenderTimingSuiteTestsandRenderVerifyTestsVwGraphicsWin32Class,_VwRootBoxClass) require STA threading — without the attribute, NUnit runs these on an MTA thread, causing intermittent access violations duringRootBox.Layoutin CIStVcTestsfixture already had this attribute correctlyTest plan
🤖 Generated with Claude Code
This change is