Conversation
NUnit Tests 1 files ±0 1 suites ±0 10m 36s ⏱️ -14s Results for commit 8dc2de1. ± Comparison against base commit 63fa9fb. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on aror92).
Src/xWorks/DictionaryExportService.cs line 116 at r1 (raw file):
} public void ExportWordClassifiedDictionary(string filePath, int[] entriesToSave, RecordClerk clerk,
When you call this method, you pass in "domainsToSave", which I think makes more sense than "entriesToSave". To avoid confusion should you change it here to "domainsToSave"?
* Add classified dictionary word export option. * Extend guideword handling to allow for multiple run styles included in a single guideword. Change-Id: I4b1a4305f66e5bea49ff52183dfbd41f25ac02b6
* Add test for guideword styles for classified dictionary * Update test for guideword styles for configured dictionary * Fix GetFirstGuidewordStylesList in WordGenerator to get at most one primary style and one beforeafterbetween style Change-Id: Ia270e5e2a5199ba3f7c64dc8771b6bac9d70f778
Include previously untracked Word ClassifiedDict export template Change-Id: I672f5ae97668223b3f4147d6d9ba4702c2e95dee
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil reviewed 2 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on aror92).
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on aror92).
Add classified dictionary word export option.
Extend guideword handling to allow for multiple run styles included in a single guideword.
Add test for guideword styles for classified dictionary
Update test for guideword styles for configured dictionary
This change is