Skip to content

LT-22476: Add Classified Dictionary word export#914

Merged
aror92 merged 3 commits into
mainfrom
LT-22476
Jun 2, 2026
Merged

LT-22476: Add Classified Dictionary word export#914
aror92 merged 3 commits into
mainfrom
LT-22476

Conversation

@aror92
Copy link
Copy Markdown
Contributor

@aror92 aror92 commented May 26, 2026

  • Add classified dictionary word export option.

  • Extend guideword handling to allow for multiple run styles included in a single guideword.

  • Add test for guideword styles for classified dictionary

  • Update test for guideword styles for configured dictionary


This change is Reviewable

@aror92 aror92 enabled auto-merge (squash) May 27, 2026 14:41
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 27, 2026

NUnit Tests

    1 files  ±0      1 suites  ±0   10m 36s ⏱️ -14s
4 207 tests +1  4 137 ✅ +2  70 💤 ±0  0 ❌  - 1 
4 216 runs  +1  4 146 ✅ +2  70 💤 ±0  0 ❌  - 1 

Results for commit 8dc2de1. ± Comparison against base commit 63fa9fb.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
SIL.FieldWorks.XWorks.LcmWordGeneratorTests ‑ GetFirstHeadwordStyle
SIL.FieldWorks.XWorks.LcmWordGeneratorTests ‑ GetGuidewordStyleForClassifiedDictionary
SIL.FieldWorks.XWorks.LcmWordGeneratorTests ‑ GetGuidewordStyleForConfiguredDictionary

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Contributor

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-sil reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on aror92).


Src/xWorks/DictionaryExportService.cs line 116 at r1 (raw file):

		}

		public void ExportWordClassifiedDictionary(string filePath, int[] entriesToSave, RecordClerk clerk,

When you call this method, you pass in "domainsToSave", which I think makes more sense than "entriesToSave". To avoid confusion should you change it here to "domainsToSave"?

aror92 added 3 commits June 2, 2026 08:17
* Add classified dictionary word export option.

* Extend guideword handling to allow for multiple
run styles included in a single guideword.

Change-Id: I4b1a4305f66e5bea49ff52183dfbd41f25ac02b6
* Add test for guideword styles for classified dictionary
* Update test for guideword styles for configured dictionary
* Fix GetFirstGuidewordStylesList in WordGenerator to get
at most one primary style and one beforeafterbetween style

Change-Id: Ia270e5e2a5199ba3f7c64dc8771b6bac9d70f778
Include previously untracked Word ClassifiedDict export template

Change-Id: I672f5ae97668223b3f4147d6d9ba4702c2e95dee
Copy link
Copy Markdown
Contributor

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-sil reviewed 2 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on aror92).

Copy link
Copy Markdown
Contributor

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-sil resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on aror92).

@aror92 aror92 merged commit 140e067 into main Jun 2, 2026
6 of 7 checks passed
@aror92 aror92 deleted the LT-22476 branch June 2, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants