Fix LT-22527: Repair the ILRepack build functionality#910
Merged
Conversation
* The SDK targets are always imported after everything in the project file. So the SDK's empty `AfterBuild` silently overwrote the one from ILRepack.targets with no warning * Change from the `AfterBuild` override pattern to `AfterTargets=Build` Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jasonleenaylor
force-pushed
the
bugfix/LT-22527
branch
from
e8e808b to
bc3d8b2
Compare
mark-sil
approved these changes
May 26, 2026
Contributor
mark-sil
left a comment
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil reviewed 5 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on jasonleenaylor).
SDK projects package references conflict with the internalized reapacked assemblies. Copy un-merged assembly before ILRepack overwrites it, then have the test project compile and run against that copy: - ILRepack.targets: copy to .PreMerge.dll and use it as ILRepack input - Test csproj: ProjectReference with ReferenceOutputAssembly=false plus explicit Reference to the PreMerge DLL via HintPath - Test App.config: codeBase redirect so the runtime loads the PreMerge copy instead of the packed DLL from the shared output directory - Directory.Packages.props: pin System.Text.Encoding.CodePages to 10.0.3 (the PreMerge HintPath reference loses NuGet graph unification, so the transitive version from SIL.Machine must be pinned explicitly) - Heat-exclude files: exclude PreMerge.dll from WiX 3 and WiX 6 harvests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jasonleenaylor
force-pushed
the
bugfix/LT-22527
branch
from
0ac45e2 to
253ed95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AfterBuildsilently overwrote the one from ILRepack.targets with no warningAfterBuildoverride pattern toAfterTargets=BuildThis change is