Skip to content

Skip Claude reviews for draft pull requests - #804

Open
justin808 wants to merge 1 commit into
mainfrom
jg-codex/issue-745-quiet-draft-reviews
Open

Skip Claude reviews for draft pull requests#804
justin808 wants to merge 1 commit into
mainfrom
jg-codex/issue-745-quiet-draft-reviews

Conversation

@justin808

@justin808 justin808 commented Sep 9, 2026

Copy link
Copy Markdown
Member

Why

Claude currently reviews every push to a draft pull request. That creates review noise before the author considers the change ready and makes the useful blocker signal hard to find.

Fixes #745.

What changed

  • Skip the Claude review job while the pull request is a draft.
  • Preserve synchronize reviews for ready pull requests.
  • Require the top-level review comment to lead with a one-line blocker verdict, collapse non-blocking detail, and reserve inline comments for confirmed blockers.

How to review and verify

  1. Check the job guard and confirm opened, synchronize, ready_for_review, and reopened events remain configured.
  2. Check that permissions, read-only checkout, and invalid-token detection are unchanged.

Test plan

  • actionlint .github/workflows/claude-code-review.yml — passed.
  • Trusted secure-github-actions-scan --json — passed with no findings.
  • Focused workflow contract assertions and git diff --check — passed.
  • Live draft/ready lifecycle — the draft opened run skipped claude-review; ready_for_review then started a new run at the same head.
  • Full clean bin/validate replay on the current base — passed, including installer and agent-stack suites; RuboCop inspected 199 files with no offenses.
  • Changelog classification: deferred_to_update_changelog.
Agent details

Commands and results

  • Independent Codex exact-head review after rebasing onto current main: PASS, no actionable findings; patch identity remained stable.
  • Local Claude review and simplify attempts returned Execution error without a report; no Claude finding or pass is claimed.
  • Live GitHub evidence confirms draft suppression and the ready-for-review trigger at the same head. The action's workflow-edit safety behavior did not post a review comment, so the new comment format is not claimed as provider-observed yet.

Exact-head and replay evidence

  • Reviewed base: ad8175a4bb37f336dc900d229fee0724a357c654
  • Reviewed head: 5ad31f018faf779768050da9ad1ae1fea06bb2c7
  • Patch ID: ddfabe3b4e7f8bc580c77a0c2d68b7970ec54d49 (unchanged across rebases).

Coordination and reviewer telemetry

  • Batch: aw-sept7-20260909; lane: issue-745.
  • Maker: aw745-worker; independent reviewer: issue745-reviewer.
  • Review covered the entire changed workflow plus triggers, permissions, checkout credentials, reviewer tools, and token-failure handling.

Decision log

  • Non-blocking: whether to remove synchronize to reduce review volume further
    • Decision: keep it.
    • Why: ready pull requests need current-head review after each push.
    • Review later: Review volume after one week of use.

Summary by CodeRabbit

  • Chores
    • Automated reviews now run only for non-draft pull requests.
    • Review results distinguish blocking issues from non-blocking feedback.
    • Inline comments are limited to confirmed blocking issues.

@github-actions github-actions Bot added the coderabbit:first-pass Triggers CodeRabbit's automatic first-pass pull-request review. label Sep 9, 2026
@justin808
justin808 marked this pull request as ready for review September 9, 2026 09:20
@github-actions github-actions Bot added the coderabbit:ready Triggers CodeRabbit's automatic review when a draft pull request becomes ready. label Sep 9, 2026
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: b218a9b7-908f-43f5-b114-6301be0993be

📥 Commits

Reviewing files that changed from the base of the PR and between ad8175a and 5ad31f0.

📒 Files selected for processing (1)
  • .github/workflows/claude-code-review.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Claude review workflow now skips draft pull requests. Its output requires a top-level BLOCKED or CLEAR verdict, places non-blocking feedback in <details>, and limits inline comments to confirmed blockers.

Changes

Claude review policy

Layer / File(s) Summary
Review execution and output policy
.github/workflows/claude-code-review.yml
The job runs only when the pull request is not a draft. The review prompt requires a top-level verdict, expandable non-blocking feedback, and inline comments only for confirmed blockers.

Estimated code review effort: 2 (Simple) | ~10 minutes

Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 5ad31

Draft pull requests now skip Claude reviews, while ready pull requests retain reviews with clearer blocker-focused output. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: Claude reviews are skipped for draft pull requests.
Description check ✅ Passed The description includes the required Why, What changed, How to review and verify, and Test plan sections. The test items are resolved with recorded results, and agent details are contained in one dis…
Linked Issues check ✅ Passed The workflow changes address issue #745: draft reviews are skipped, ready-pull-request reviews remain enabled, review output rules are updated, inline comments are restricted to confirmed blockers, an…
Out of Scope Changes check ✅ Passed The changes are limited to the Claude review workflow and directly support the requirements in issue #745. No unrelated code or configuration changes are identified.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jg-codex/issue-745-quiet-draft-reviews

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T03:00:00.774529Z 5ad31f0 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@justin808
justin808 force-pushed the jg-codex/issue-745-quiet-draft-reviews branch 3 times, most recently from aac08c9 to 6192c06 Compare September 9, 2026 12:12
@justin808
justin808 force-pushed the jg-codex/issue-745-quiet-draft-reviews branch from 6192c06 to 5ad31f0 Compare September 10, 2026 02:57
@justin808 justin808 added the human-attention:walkthrough The complete exact-head walkthrough is published; the next action is the human's read label Sep 10, 2026
@justin808

Copy link
Copy Markdown
Member Author

🤖 Codex

Exact-head refresh after upstream main advanced:

  • Rebased patch-identically onto base ad8175a.
  • Current head: 5ad31f0.
  • Stable patch ID: ddfabe3b4e7f8bc580c77a0c2d68b7970ec54d49.
  • Full clean bin/validate passed, including installer and agent-stack suites; RuboCop inspected 199 files with no offenses.
  • The configured infrastructure-delivery and GitHub-workflow human gates still apply; no autonomous merge is claimed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coderabbit:first-pass Triggers CodeRabbit's automatic first-pass pull-request review. coderabbit:ready Triggers CodeRabbit's automatic review when a draft pull request becomes ready. human-attention:walkthrough The complete exact-head walkthrough is published; the next action is the human's read

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip draft pushes in the Claude review Action and shape its output

1 participant