Skip to content

Preserve backlog recovery plan and case-study evidence - #764

Merged
justin808 merged 5 commits into
mainfrom
jg-codex/backlog-recovery-records
Sep 6, 2026
Merged

justin808 merged 5 commits into
mainfrom
jg-codex/backlog-recovery-records

Conversation

@justin808

@justin808 justin808 commented Sep 5, 2026 •

Copy link
Copy Markdown
Member

Why

Preserve the backlog investigation and case-study evidence in a shared, versioned location, with current ownership clearly separated from the original September 5 plan. PR #695 has merged; its archived follow-ups must not be automatically restarted.

What changed

  • Add the recovery plan and evidence notebook under docs/plans and docs/postmortems, with source links, the eight parked optional issues, and explicit measurement limits.
  • Add a September 6 status note linking the #695 archive disposition. The continuation brake and five-PR pilot were not shipped by Add task-scoped review contract and replay reducer #695 and remain separately prioritized by the maintainer and AW Portfolio Control Tower.
  • Preserve the earlier plan as history. Current guidance requires the maintainer and tower to reconcile finishing ownership before implementation resumes. Integration/refactoring options do not admit new work or assign an implementation owner.

Refs #392 and #742; neither issue is closed by this PR.

How to review and verify

Start with the dated status update in each document, then inspect the original observations and source links. The final diff contains only these two Markdown files. The CodeRabbit permission correction from an earlier branch commit already landed in #765; bringing current main into this branch removes that duplicate workflow change from this PR's diff.

Test plan

  • Markdownlint on both changed documents: passed with zero issues.
  • Direct relative-link check over both changed documents: all four local links resolve; both link the Add task-scoped review contract and replay reducer #695 archive disposition.
  • Whitespace and scope checks: passed; exactly two Markdown files differ from current main. CHANGELOG.md and the lifecycle workflow match the base.
  • Current-head hosted validation and lint passed; all five review threads are resolved with verified replies and recorded provider limitations.
  • Lifecycle label job: passed on the ready-for-review event at 1857e130; its workflow is unchanged in the final documentation-only repair and does not trigger on synchronize events.
  • Changelog classification: deferred_to_update_changelog.
Agent details

Commands and results

  • markdownlint-cli2 docs/plans/2026-09-05-backlog-recovery-plan.md docs/postmortems/2026-09-05-verification-backlog-case-study.md: passed.

  • A direct Python read of Markdown links in those two files checked each relative target against the filesystem: four links passed. This is the coverage for the new files' relative links.

  • git diff --check origin/main...HEAD: passed.

  • git diff --exit-code origin/main HEAD -- .github/workflows/coderabbit-lifecycle-review.yml CHANGELOG.md: passed.

  • Earlier ruby bin/validate-doc-links and ruby bin/validate-solutions runs passed but inspect other existing documents; they do not validate these two new files. This corrects the coverage implication identified in the review comment.

  • Local bin/validate was invoked before the documentation commit and deliberately interrupted. No full local pass is claimed. Focused documentation checks use the existing Local Validation Gate. Fresh hosted full validation passed on the final candidate; the interrupted local runs are not used as passing evidence.

  • The secure-github-actions scan and actionlint found no issue in the one-line permission correction before base reconciliation. That correction is already present in base via Fix CodeRabbit lifecycle label permissions #765 and is outside the final authored diff.

  • Independent review of the initial candidate: codex review --base origin/main exited 0 with no actionable defects. It inspected the full two-document branch diff and verified the current-status claims against the linked GitHub decisions. Correctness/source fidelity and process/ownership were covered; executable-code security is not applicable to the final documentation-only diff. A later hosted review identified one residual present-tense owner assumption; the final two-line repair removes it and adds the missing Add opt-in interrupted task recovery to chat audit #762 source link. Independent codex review --commit ff614e299231a7b564790943baebdabe9cad5ecb exited 0 with no actionable defects; it confirmed that the ownership correction and source link agree with the surrounding documentation and linked closeout decision.

  • Final-head Claude workflow run ended green but reports 19 tool-permission denials and no new published review artifact. Its coverage is degraded, not a clean review. Review evidence is the independent full-diff Codex pass at 1857e130 plus the clean exact-commit repair review at ff614e29; unchanged files retain their original review coverage. The final authored diff is historical documentation only; the repo seam requires independent code review for non-trivial workflow/helper changes, neither of which is present here. This records the existing review-infrastructure limitation without widening tool permissions or adding an infrastructure lane.

  • Final-head full Validate run: passed at 2026-09-06 06:37:52 UTC on ff614e299231a7b564790943baebdabe9cad5ecb; the job took 35 minutes 9 seconds, including setup and cleanup. Lint also passed on that head.

  • Final thread-aware readback: five resolved threads, zero unresolved threads, complete pagination. No pending or changes-requested formal reviews were returned. Fresh security preflight: SECURITY_PREFLIGHT_OK, two documentation files, no high-risk changed paths, no untrusted actor or coverage findings.

Exact-head and replay evidence

Base: ed425c722e53eb1efec1d81d97027d5644aeef0a. Candidate: ff614e299231a7b564790943baebdabe9cad5ecb. Final authored scope: two Markdown documents, 273 added lines. The normal merge from current main preserved existing work and required no conflict resolution. Old-head checks are not evidence for this candidate.

The #4980 continuation-brake replay and five-PR adoption experiment remain future work under #392. This PR records their disposition; it does not implement them or claim that they passed.

Decision log

  • Non-blocking: keep the original plan as a dated historical record, with the later Add task-scoped review contract and replay reducer #695 disposition prominently superseding its pending-owner instructions. This preserves the case-study history while preventing stale task admission.
  • Non-blocking: preserve optional suggestions in the existing register and issue rather than creating new implementation tasks.
  • Non-blocking: the earlier failed lifecycle run belongs to an old candidate. Fix CodeRabbit lifecycle label permissions #765 delivered the permission fix independently; the ready-for-review lifecycle run successfully applied the label. The final repair changes only documentation.
  • Non-blocking: CodeRabbit reported a green status but explicitly skipped automatic review because of its repository eligibility rule. This is an advisory skip, not a clean code-review receipt; configured Claude and independent Codex coverage are recorded separately.

Review dispositions

@claude

claude Bot commented Sep 5, 2026

Copy link
Copy Markdown

Review

This PR is documentation-only (two new Markdown files under docs/plans/ and docs/postmortems/, no executable code), so the usual bug/security/performance dimensions mostly don't apply. I spot-checked the factual claims and cross-references against live GitHub state:

So the content itself appears carefully sourced.

One thing worth fixing: the test-plan's validator claims are misleading.

The PR description says:

  • Existing routing-doc and solution-doc validators: passed.
  • ruby bin/validate-doc-links: passed, one routing doc.
  • ruby bin/validate-solutions: passed, two solution docs.

These commands did run and did exit 0, but neither one actually checks the files this PR adds:

  • bin/validate-doc-links hardcodes CHECKED_DOCUMENTS = ["docs/operator-handbook.md"] — it only ever validates that one file, untouched by this PR.
  • bin/validate-solutions only globs docs/solutions/*.md — the "two solution docs" it found are pre-existing files (coordination-unknown-state.md, github-content-is-evidence.md), not the new docs/plans//docs/postmortems/ files.

So the link-checking for the two new documents was entirely manual ("Relative-link and source-reference checks" bullet), not covered by either automated gate. Given this PR's own thesis is about not conflating "a check ran" with "the check verified this," it'd be worth rewording the test plan to make clear those two validator runs are unrelated to the new files' links, rather than implying they covered them.

Minor/non-blocking: current CI shows the "CodeRabbit Lifecycle Review / request-review" check as FAILURE — probably unrelated to this diff's content, but worth a glance before merge.

@justin808 justin808 added the coderabbit:first-pass Triggers CodeRabbit's automatic first-pass pull-request review. label Sep 5, 2026
…very-records

* origin/main:
  Add task-scoped review contract and replay reducer (#695)
  Fix trusted CI hold policy and canonical diff identity (#737)
  Clarify explicit structural review after batch audits (#754)
  Bump actions/checkout from 4.4.0 to 7.0.1 (#301)
  Bump actions/setup-node from 6.5.0 to 7.0.0 (#628)
  Test review-wave check classification behavior (#678)
  Preserve authorized completion and reuse valid local verification (#758)
  Fix CodeRabbit lifecycle label permissions (#765)
  Add opt-in interrupted task recovery to chat audit (#762)
@justin808
justin808 marked this pull request as ready for review September 6, 2026 05:51
@github-actions github-actions Bot added the coderabbit:ready Triggers CodeRabbit's automatic review when a draft pull request becomes ready. label Sep 6, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-06T06:14:35.120002Z ff614e2 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 8cddef9e-83c1-4720-8beb-b90acfe980d7


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread docs/plans/2026-09-05-backlog-recovery-plan.md
@claude

claude Bot commented Sep 6, 2026

Copy link
Copy Markdown

Review summary

This PR is documentation-only — two new Markdown files under docs/plans/ and docs/postmortems/, no executable code, workflow, or CI changes. That removes most of the usual code-quality/security/performance surface, so I focused the review on internal consistency and link correctness of the new content:

One naming nit posted inline: "AW Portfolio Control Tower" (used as a routing target for future decisions) doesn't exactly match the canonical task name AW Control Tower — Backlog Reduction used in docs/control-tower-prompts.md.

No security or performance concerns — this PR adds no executable code.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1857e130bc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/plans/2026-09-05-backlog-recovery-plan.md Outdated
Comment thread docs/postmortems/2026-09-05-verification-backlog-case-study.md
Comment thread docs/plans/2026-09-05-backlog-recovery-plan.md
Comment thread docs/plans/2026-09-05-backlog-recovery-plan.md
@claude

claude Bot commented Sep 6, 2026

Copy link
Copy Markdown

Review summary

This PR adds two documentation-only files (a backlog recovery plan and a case-study evidence notebook) — no code, functions, or executable logic changed, so most standard code-review angles (bugs, security, performance, removed behavior) don't apply. Reviewed for internal consistency and verifiability instead. Left 3 inline comments:

  1. Missing source link — docs/postmortems/.../case-study.md: PR Add opt-in interrupted task recovery to chat audit #762 is cited as evidence (line 18) but has no corresponding link in the "Primary source links" list, unlike its sibling Docs: record the ROR #4980 review-churn failure #761.
  2. Duplicated, independently-worded status section — the "Status update" sections in the plan and its companion case-study doc restate the same facts in different wording with no canonical cross-reference, risking silent drift on future edits.
  3. Undefined authoritative entities — "AW Portfolio Control Tower" and "AW Closeout — PR Add task-scoped review contract and replay reducer #695" are treated as authoritative throughout the plan but aren't defined or linked anywhere in the repo.

All are minor documentation-consistency nits; nothing blocking.

@justin808
justin808 merged commit 7a5018e into main Sep 6, 2026
14 checks passed
@justin808
justin808 deleted the jg-codex/backlog-recovery-records branch September 6, 2026 06:41
justin808 added a commit that referenced this pull request Sep 6, 2026
…edia-attachments

* origin/main:
  Preserve backlog recovery plan and case-study evidence (#764)
justin808 added a commit that referenced this pull request Sep 6, 2026
Conflict: docs/README.md. Main (#741) added the ADR 0005 index row
directly above the three docs/plans/ implementation-plan rows that this
branch replaces with project/plans/ archive links. Resolved by keeping
the ADR 0005 row followed by this branch's two archive rows (the Project
Plans index and the relocated Multi-Repository Control Towers plan), and
dropping main's three stale docs/plans/ rows.

Main's new docs/plans/2026-09-05-backlog-recovery-plan.md (#764) is a
backlog-governance record rather than a technical implementation plan,
so it stays in docs/plans/ with the other design and workflow documents;
its only inbound link, from docs/postmortems/, is unchanged.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
justin808 added a commit that referenced this pull request Sep 6, 2026
…mpanion-path-preflight

* origin/main: (34 commits)
  Raise the workflow byte caps until the #392 extraction lands (#776)
  Classify GitHub intake lookup failures safely (#673)
  Grant the control tower explicit integration authority and trim its prompts (#749)
  Record merge-authority decisions in CONTEXT.md and ADR 0005 (#741)
  Preserve backlog recovery plan and case-study evidence (#764)
  Add task-scoped review contract and replay reducer (#695)
  Fix trusted CI hold policy and canonical diff identity (#737)
  Clarify explicit structural review after batch audits (#754)
  Bump actions/checkout from 4.4.0 to 7.0.1 (#301)
  Bump actions/setup-node from 6.5.0 to 7.0.0 (#628)
  Test review-wave check classification behavior (#678)
  Preserve authorized completion and reuse valid local verification (#758)
  Fix CodeRabbit lifecycle label permissions (#765)
  Add opt-in interrupted task recovery to chat audit (#762)
  Tune CodeRabbit lifecycle reviews (#763)
  Record why the ROR 4980 review loop failed to converge (#761)
  Add action-first chat audit skill (#752)
  Clarify structural-review as a separate audit axis (#710)
  Feature the ShakaCode Agents documentation site (#727)
  Validate Claude skill metadata (#670)
  ...
justin808 added a commit that referenced this pull request Sep 6, 2026
…/issue-332-replicate-ci-crosslink-m1

* commit '4f82c7dea80fe7815fb6190b554da23bb85b645f':
  Classify GitHub intake lookup failures safely (#673)
  Grant the control tower explicit integration authority and trim its prompts (#749)
  Record merge-authority decisions in CONTEXT.md and ADR 0005 (#741)
  Preserve backlog recovery plan and case-study evidence (#764)
  Add task-scoped review contract and replay reducer (#695)
  Fix trusted CI hold policy and canonical diff identity (#737)
  Clarify explicit structural review after batch audits (#754)
  Bump actions/checkout from 4.4.0 to 7.0.1 (#301)
  Bump actions/setup-node from 6.5.0 to 7.0.0 (#628)
  Test review-wave check classification behavior (#678)
  Preserve authorized completion and reuse valid local verification (#758)
  Fix CodeRabbit lifecycle label permissions (#765)
  Add opt-in interrupted task recovery to chat audit (#762)
  Tune CodeRabbit lifecycle reviews (#763)
  Record why the ROR 4980 review loop failed to converge (#761)
  Add action-first chat audit skill (#752)
  Clarify structural-review as a separate audit axis (#710)
  Feature the ShakaCode Agents documentation site (#727)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coderabbit:first-pass Triggers CodeRabbit's automatic first-pass pull-request review. coderabbit:ready Triggers CodeRabbit's automatic review when a draft pull request becomes ready.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant