Repository navigation
Preserve backlog recovery plan and case-study evidence - #764
Conversation
ReviewThis PR is documentation-only (two new Markdown files under
So the content itself appears carefully sourced. One thing worth fixing: the test-plan's validator claims are misleading. The PR description says:
These commands did run and did exit 0, but neither one actually checks the files this PR adds:
So the link-checking for the two new documents was entirely manual ("Relative-link and source-reference checks" bullet), not covered by either automated gate. Given this PR's own thesis is about not conflating "a check ran" with "the check verified this," it'd be worth rewording the test plan to make clear those two validator runs are unrelated to the new files' links, rather than implying they covered them. Minor/non-blocking: current CI shows the "CodeRabbit Lifecycle Review / request-review" check as FAILURE — probably unrelated to this diff's content, but worth a glance before merge. |
…very-records * origin/main: Add task-scoped review contract and replay reducer (#695) Fix trusted CI hold policy and canonical diff identity (#737) Clarify explicit structural review after batch audits (#754) Bump actions/checkout from 4.4.0 to 7.0.1 (#301) Bump actions/setup-node from 6.5.0 to 7.0.0 (#628) Test review-wave check classification behavior (#678) Preserve authorized completion and reuse valid local verification (#758) Fix CodeRabbit lifecycle label permissions (#765) Add opt-in interrupted task recovery to chat audit (#762)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review summaryThis PR is documentation-only — two new Markdown files under
One naming nit posted inline: "AW Portfolio Control Tower" (used as a routing target for future decisions) doesn't exactly match the canonical task name No security or performance concerns — this PR adds no executable code. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1857e130bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Review summaryThis PR adds two documentation-only files (a backlog recovery plan and a case-study evidence notebook) — no code, functions, or executable logic changed, so most standard code-review angles (bugs, security, performance, removed behavior) don't apply. Reviewed for internal consistency and verifiability instead. Left 3 inline comments:
All are minor documentation-consistency nits; nothing blocking. |
…edia-attachments * origin/main: Preserve backlog recovery plan and case-study evidence (#764)
Conflict: docs/README.md. Main (#741) added the ADR 0005 index row directly above the three docs/plans/ implementation-plan rows that this branch replaces with project/plans/ archive links. Resolved by keeping the ADR 0005 row followed by this branch's two archive rows (the Project Plans index and the relocated Multi-Repository Control Towers plan), and dropping main's three stale docs/plans/ rows. Main's new docs/plans/2026-09-05-backlog-recovery-plan.md (#764) is a backlog-governance record rather than a technical implementation plan, so it stays in docs/plans/ with the other design and workflow documents; its only inbound link, from docs/postmortems/, is unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…mpanion-path-preflight * origin/main: (34 commits) Raise the workflow byte caps until the #392 extraction lands (#776) Classify GitHub intake lookup failures safely (#673) Grant the control tower explicit integration authority and trim its prompts (#749) Record merge-authority decisions in CONTEXT.md and ADR 0005 (#741) Preserve backlog recovery plan and case-study evidence (#764) Add task-scoped review contract and replay reducer (#695) Fix trusted CI hold policy and canonical diff identity (#737) Clarify explicit structural review after batch audits (#754) Bump actions/checkout from 4.4.0 to 7.0.1 (#301) Bump actions/setup-node from 6.5.0 to 7.0.0 (#628) Test review-wave check classification behavior (#678) Preserve authorized completion and reuse valid local verification (#758) Fix CodeRabbit lifecycle label permissions (#765) Add opt-in interrupted task recovery to chat audit (#762) Tune CodeRabbit lifecycle reviews (#763) Record why the ROR 4980 review loop failed to converge (#761) Add action-first chat audit skill (#752) Clarify structural-review as a separate audit axis (#710) Feature the ShakaCode Agents documentation site (#727) Validate Claude skill metadata (#670) ...
…/issue-332-replicate-ci-crosslink-m1 * commit '4f82c7dea80fe7815fb6190b554da23bb85b645f': Classify GitHub intake lookup failures safely (#673) Grant the control tower explicit integration authority and trim its prompts (#749) Record merge-authority decisions in CONTEXT.md and ADR 0005 (#741) Preserve backlog recovery plan and case-study evidence (#764) Add task-scoped review contract and replay reducer (#695) Fix trusted CI hold policy and canonical diff identity (#737) Clarify explicit structural review after batch audits (#754) Bump actions/checkout from 4.4.0 to 7.0.1 (#301) Bump actions/setup-node from 6.5.0 to 7.0.0 (#628) Test review-wave check classification behavior (#678) Preserve authorized completion and reuse valid local verification (#758) Fix CodeRabbit lifecycle label permissions (#765) Add opt-in interrupted task recovery to chat audit (#762) Tune CodeRabbit lifecycle reviews (#763) Record why the ROR 4980 review loop failed to converge (#761) Add action-first chat audit skill (#752) Clarify structural-review as a separate audit axis (#710) Feature the ShakaCode Agents documentation site (#727)
Why
Preserve the backlog investigation and case-study evidence in a shared, versioned location, with current ownership clearly separated from the original September 5 plan. PR #695 has merged; its archived follow-ups must not be automatically restarted.
What changed
docs/plansanddocs/postmortems, with source links, the eight parked optional issues, and explicit measurement limits.Refs #392 and #742; neither issue is closed by this PR.
How to review and verify
Start with the dated status update in each document, then inspect the original observations and source links. The final diff contains only these two Markdown files. The CodeRabbit permission correction from an earlier branch commit already landed in #765; bringing current main into this branch removes that duplicate workflow change from this PR's diff.
Test plan
CHANGELOG.mdand the lifecycle workflow match the base.1857e130; its workflow is unchanged in the final documentation-only repair and does not trigger on synchronize events.deferred_to_update_changelog.Agent details
Commands and results
markdownlint-cli2 docs/plans/2026-09-05-backlog-recovery-plan.md docs/postmortems/2026-09-05-verification-backlog-case-study.md: passed.A direct Python read of Markdown links in those two files checked each relative target against the filesystem: four links passed. This is the coverage for the new files' relative links.
git diff --check origin/main...HEAD: passed.git diff --exit-code origin/main HEAD -- .github/workflows/coderabbit-lifecycle-review.yml CHANGELOG.md: passed.Earlier
ruby bin/validate-doc-linksandruby bin/validate-solutionsruns passed but inspect other existing documents; they do not validate these two new files. This corrects the coverage implication identified in the review comment.Local
bin/validatewas invoked before the documentation commit and deliberately interrupted. No full local pass is claimed. Focused documentation checks use the existing Local Validation Gate. Fresh hosted full validation passed on the final candidate; the interrupted local runs are not used as passing evidence.The secure-github-actions scan and actionlint found no issue in the one-line permission correction before base reconciliation. That correction is already present in base via Fix CodeRabbit lifecycle label permissions #765 and is outside the final authored diff.
Independent review of the initial candidate:
codex review --base origin/mainexited 0 with no actionable defects. It inspected the full two-document branch diff and verified the current-status claims against the linked GitHub decisions. Correctness/source fidelity and process/ownership were covered; executable-code security is not applicable to the final documentation-only diff. A later hosted review identified one residual present-tense owner assumption; the final two-line repair removes it and adds the missing Add opt-in interrupted task recovery to chat audit #762 source link. Independentcodex review --commit ff614e299231a7b564790943baebdabe9cad5ecbexited 0 with no actionable defects; it confirmed that the ownership correction and source link agree with the surrounding documentation and linked closeout decision.Final-head Claude workflow run ended green but reports 19 tool-permission denials and no new published review artifact. Its coverage is degraded, not a clean review. Review evidence is the independent full-diff Codex pass at
1857e130plus the clean exact-commit repair review atff614e29; unchanged files retain their original review coverage. The final authored diff is historical documentation only; the repo seam requires independent code review for non-trivial workflow/helper changes, neither of which is present here. This records the existing review-infrastructure limitation without widening tool permissions or adding an infrastructure lane.Final-head full Validate run: passed at 2026-09-06 06:37:52 UTC on
ff614e299231a7b564790943baebdabe9cad5ecb; the job took 35 minutes 9 seconds, including setup and cleanup. Lint also passed on that head.Final thread-aware readback: five resolved threads, zero unresolved threads, complete pagination. No pending or changes-requested formal reviews were returned. Fresh security preflight:
SECURITY_PREFLIGHT_OK, two documentation files, no high-risk changed paths, no untrusted actor or coverage findings.Exact-head and replay evidence
Base:
ed425c722e53eb1efec1d81d97027d5644aeef0a. Candidate:ff614e299231a7b564790943baebdabe9cad5ecb. Final authored scope: two Markdown documents, 273 added lines. The normal merge from current main preserved existing work and required no conflict resolution. Old-head checks are not evidence for this candidate.The #4980 continuation-brake replay and five-PR adoption experiment remain future work under #392. This PR records their disposition; it does not implement them or claim that they passed.
Decision log
Review dispositions
docs/control-tower-prompts.mdpresents a recommended first layout, not evidence that this existing task was renamed or is an alias.