Skip to content

Clarify reordered marker contract - #723

Closed
justin808 wants to merge 1 commit into
mainfrom
jg-codex/issue-283-reordered-marker-contract
Closed

justin808 wants to merge 1 commit into
mainfrom
jg-codex/issue-283-reordered-marker-contract

Conversation

@justin808

Copy link
Copy Markdown
Member

Fixes #283

deferred_to_update_changelog

Summary:

  • Reword the Unblock Block rule to define (reordered) as the promoted entry.
  • Update the worked example so only the promoted entry is marked.
  • Align the contract test with that interpretation.

Validation:

  • ruby skills/pr-batch/bin/goal-completion-contract-test.rb
  • git diff --check
  • bin/lint (rubocop and shellcheck pass; markdownlint stops because yamllint is unavailable in this environment)

@justin808 justin808 added the deferred_to_update_changelog Changelog deferred to dedicated update-changelog lane label Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread workflows/pr-batch-unblock.md Resolved
@justin808 justin808 added agent-claimed Active agent coordination claim; reconciled from private backend and removed agent-claimed Active agent coordination claim; reconciled from private backend labels Sep 3, 2026
@justin808 justin808 added complexity:neutral Bounded repair, tests, docs or evidence with little net structural change. Not merge approval. P2 Useful follow-up: schedule after higher-impact work triage:drain-first Resolve the existing PR or concrete blocker before starting more work. Not merge approval. labels Sep 10, 2026
@justin808

Copy link
Copy Markdown
Member Author

Retired after current-main review. The proposed singular marker contract is incomplete for multiple promoted entries (the only review finding), while #283 still requires a maintainer decision. main retains the existing position-based contract; this stale draft is closed rather than repaired speculatively.

@justin808 justin808 closed this Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity:neutral Bounded repair, tests, docs or evidence with little net structural change. Not merge approval. deferred_to_update_changelog Changelog deferred to dedicated update-changelog lane P2 Useful follow-up: schedule after higher-impact work triage:drain-first Resolve the existing PR or concrete blocker before starting more work. Not merge approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unblock Block worked example contradicts its own (reordered) rule in a two-entry swap

1 participant