Repository navigation
automotive, inet6, automaton: stabilize CI timeouts and fix Windows select_objects - #5234
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5234 +/- ##
==========================================
+ Coverage 80.62% 81.19% +0.56%
==========================================
Files 394 394
Lines 98742 98758 +16
==========================================
+ Hits 79611 80185 +574
+ Misses 19131 18573 -558
🚀 New features to boost your workflow:
|
BenGardiner
force-pushed
the
fix-doip-test-timeout
branch
from
October 18, 2026 00:33
79b4beb to
94570ca
Compare
polybassa
requested changes
Oct 18, 2026
BenGardiner
force-pushed
the
fix-doip-test-timeout
branch
from
October 18, 2026 23:13
94570ca to
09a3f46
Compare
BenGardiner
changed the title
polybassa
reviewed
Oct 20, 2026
polybassa
left a comment
polybassa
left a comment
Contributor
There was a problem hiding this comment.
Please add a Windows regression case with a negative-fileno input, an unreadable event input, and a readable event input, asserting that the unreadable input is excluded in more than one input ordering. Also cache each object’s fileno() once and append each event alongside its corresponding input mapping. This review comment was written with the help of AI (GPT-6).
In test/contrib/automotive/doip.uts:439, rx_sock.sr() with multi=True used a 0.1s timeout to collect 8 pre-queued responses. On loaded CI runners, the timeout could expire before all responses were processed. Increase timeout to 0.5s. AI-Assisted: yes (GPT-5.6-Cyber)
When whois resolution returns no records, AS_resolver6._resolve_one() raised AttributeError attempting to call startswith() on None. Guard asn checks and allow for empty/rate-limited responses in regression tests. AI-Assisted: yes (GPT-5.6-Cyber)
…ze TLS test timeouts In scapy/automaton.py, select_objects() on Windows handles objects with negative file descriptors (such as PcapReader) by appending them directly to results and omitting them from events. When WaitForMultipleObjects returns an event index, looking up inputs[res] was offset by any preceding negative-fileno objects, resulting in incorrect return sets. Map events to input objects explicitly via events_to_inputs, caching each object's fileno() once and appending each event alongside its input mapping. In test/scapy/layers/tls/tlsclientserver.uts, increase the server accept and client handshake request timeouts in test_tls_client_native from 1s to 5s to avoid intermittent timeouts on CPU-throttled Windows CI runners. In test/windows.uts, add unit test coverage for select_objects with negative-fileno, unreadable, and readable event inputs across multiple input orderings. AI-Assisted: yes (GPT-5.6-Cyber)
AI-Assisted: Yes Kimi 2.7 / GPT 5.4 codex / Copilot
BenGardiner
force-pushed
the
fix-doip-test-timeout
branch
from
October 22, 2026 00:46
a3be136 to
9218656
Compare
On Ubuntu Azure runners with newer kernels (such as 7.0.0-1017-azure), the matching linux-modules-extra package may not exist in the package repository, causing apt-get to fail and aborting the CI setup before tests run. Allow linux-modules-extra installation to fail without aborting install.sh. AI-Assisted: yes (GPT-5.6-Cyber)
Contributor
Author
good idea. how's this now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses several CI test issues across platforms:
This message was written with the help of AI (GPT-5.6-Cyber).