Skip to content

Remove unused DataStax Astra support - #1034

Open
dkropachev wants to merge 1 commit into
scylla-4.xfrom
cleanup/1026-remove-astra
Open

Remove unused DataStax Astra support#1034
dkropachev wants to merge 1 commit into
scylla-4.xfrom
cleanup/1026-remove-astra

Conversation

@dkropachev

Copy link
Copy Markdown

Closes #1026. Part of #1025.

What and why

Remove DataStax Astra secure-connect-bundle parsing, topology/SNI routing, public configuration, examples, and tests. ScyllaDB does not use or test this path, so deleting it reduces unverified production and test code that the team must support.

Scylla client routes/private-endpoint support is preserved.

Validation

  • mvn -pl core clean test — 3,955 unit tests and 76 Reactive Streams TCK checks passed.
  • mvn -pl core -DskipTests verify
  • mvn -pl examples -DskipTests package
  • Full fast reactor compiled through integration and OSGi modules; its distribution assembly then hit the existing -Pfast/missing-sources incompatibility.

Dependencies: none. Cherry-picked commits: none.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Team

Run ID: 02d027f5-7f94-467d-a104-c800a4184a8c

📥 Commits

Reviewing files that changed from the base of the PR and between a0fb0bd and cca0952.

📒 Files selected for processing (5)
  • core/pom.xml
  • core/src/main/java/com/datastax/oss/driver/internal/core/channel/ChannelFactory.java
  • examples/src/main/java/com/datastax/oss/driver/examples/mapper/KillrVideoMapperExample.java
  • integration-tests/pom.xml
  • pom.xml
💤 Files with no reviewable changes (2)
  • integration-tests/pom.xml
  • core/src/main/java/com/datastax/oss/driver/internal/core/channel/ChannelFactory.java

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The PR removes DataStax Astra secure-connect-bundle support from public APIs, session construction, cloud topology, SNI SSL handling, and cloud-specific consistency handling. It removes the cloud configuration block, Astra tests and fixtures, and the Astra example. Client-routes documentation no longer lists secure-connect bundles as a conflicting configuration. Example content now references ScyllaDB.

Suggested reviewers: nikagra, scylladb-promoter

Merge Risk: ⚪ Minimal · up to cca09

The PR removes unsupported Astra functionality while preserving Scylla routes and private-endpoint support; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (2 skipped: 2 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The PR title 'Remove unused DataStax Astra support' directly and clearly summarizes the primary change. The changeset removes DataStax Astra secure-connect-bundle parsing, topology/SNI routing, config…
Description check ✅ Passed The PR description is directly related to the changeset. It explains why the changes were made (ScyllaDB does not use this path), what was removed (secure-connect-bundle parsing, topology/SNI routing,…
Linked Issues check ✅ Passed The PR fully satisfies all acceptance criteria from issue #1026: (1) All withCloudSecureConnectBundle methods removed from SessionBuilder; CloudConfig, CloudConfigFactory, CloudTopologyMonitor, SniE…
Out of Scope Changes check ✅ Passed Minor out-of-scope updates to KillrVideoMapperExample.java (updated video names and YouTube URL to reference ScyllaDB instead of Astra) and updates to documentation (address_resolution/README.md, upgr…
Full details: Title check

Explanation

The PR title 'Remove unused DataStax Astra support' directly and clearly summarizes the primary change. The changeset removes DataStax Astra secure-connect-bundle parsing, topology/SNI routing, configuration, examples, and tests.

Full details: Description check

Explanation

The PR description is directly related to the changeset. It explains why the changes were made (ScyllaDB does not use this path), what was removed (secure-connect-bundle parsing, topology/SNI routing, configuration, examples, tests), and what was preserved (Scylla client-routes support). It includes validation results.

Full details: Linked Issues check

Explanation

The PR fully satisfies all acceptance criteria from issue #1026: (1) All withCloudSecureConnectBundle methods removed from SessionBuilder; CloudConfig, CloudConfigFactory, CloudTopologyMonitor, SniEndPoint, and SniSslEngineFactory classes deleted; CLOUD_SECURE_CONNECT_BUNDLE configuration constants removed. (2) CloudConfigFactoryTest, CloudIT, SniProxyRule, SniProxyServer test files deleted; cloud fixtures removed. (3) ClientRoutesConfigFromFileTest still compiles and updated to remove the mutual-exclusion test with secure-connect-bundle. (4) PR validation shows 3,955 unit tests and 76 TCK checks passed. Scylla client-routes support is preserved (ProgrammaticArguments getters removed were cloud-specific proxy methods, not client-routes).

Full details: Out of Scope Changes check

Explanation

Minor out-of-scope updates to KillrVideoMapperExample.java (updated video names and YouTube URL to reference ScyllaDB instead of Astra) and updates to documentation (address_resolution/README.md, upgrade_guide/README.md) to remove references to cloud secure-connect-bundle mutual exclusion. These are appropriate housekeeping changes reflecting the removal of Astra support and do not introduce unrelated functionality.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (2 skipped: 2 unsupported.)

  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dkropachev
dkropachev force-pushed the cleanup/1026-remove-astra branch from a6a40b9 to cca0952 Compare September 1, 2026 15:33
@dkropachev
dkropachev requested a review from nikagra September 1, 2026 15:46
@dkropachev dkropachev self-assigned this Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove DataStax Astra secure-connect-bundle support

1 participant