Remove unused DataStax Astra support - #1034
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Team Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe PR removes DataStax Astra secure-connect-bundle support from public APIs, session construction, cloud topology, SNI SSL handling, and cloud-specific consistency handling. It removes the cloud configuration block, Astra tests and fixtures, and the Astra example. Client-routes documentation no longer lists secure-connect bundles as a conflicting configuration. Example content now references ScyllaDB. Suggested reviewers: Merge Risk: ⚪ Minimal · up to The PR removes unsupported Astra functionality while preserving Scylla routes and private-endpoint support; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Title checkExplanation The PR title 'Remove unused DataStax Astra support' directly and clearly summarizes the primary change. The changeset removes DataStax Astra secure-connect-bundle parsing, topology/SNI routing, configuration, examples, and tests. Full details: Description checkExplanation The PR description is directly related to the changeset. It explains why the changes were made (ScyllaDB does not use this path), what was removed (secure-connect-bundle parsing, topology/SNI routing, configuration, examples, tests), and what was preserved (Scylla client-routes support). It includes validation results. Full details: Linked Issues checkExplanation The PR fully satisfies all acceptance criteria from issue Full details: Out of Scope Changes checkExplanation Minor out-of-scope updates to KillrVideoMapperExample.java (updated video names and YouTube URL to reference ScyllaDB instead of Astra) and updates to documentation (address_resolution/README.md, upgrade_guide/README.md) to remove references to cloud secure-connect-bundle mutual exclusion. These are appropriate housekeeping changes reflecting the removal of Astra support and do not introduce unrelated functionality. Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (2 skipped: 2 unsupported.)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
a0fb0bd to
a6a40b9
Compare
a6a40b9 to
cca0952
Compare
Closes #1026. Part of #1025.
What and why
Remove DataStax Astra secure-connect-bundle parsing, topology/SNI routing, public configuration, examples, and tests. ScyllaDB does not use or test this path, so deleting it reduces unverified production and test code that the team must support.
Scylla client routes/private-endpoint support is preserved.
Validation
mvn -pl core clean test— 3,955 unit tests and 76 Reactive Streams TCK checks passed.mvn -pl core -DskipTests verifymvn -pl examples -DskipTests package-Pfast/missing-sources incompatibility.Dependencies: none. Cherry-picked commits: none.