perf: welford's algorithm for mean-var aggregation#4147
Open
ilan-gold wants to merge 3 commits into
Open
Conversation
ilan-gold
commented
Jun 8, 2026
| out[cat, col] += data.data[j] | ||
|
|
||
|
|
||
| @njit |
Contributor
Author
There was a problem hiding this comment.
We should make these nogil or provide an option for fau to provide nogil njit
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4147 +/- ##
==========================================
- Coverage 79.61% 79.60% -0.02%
==========================================
Files 120 120
Lines 12786 12780 -6
==========================================
- Hits 10180 10173 -7
- Misses 2606 2607 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From discussions with @zboldyga.
This should then in theory be reused with #4143 instead of its custom moments calculation