Skip to content

Interface solveProbingLPWithPricing()#1215

Merged
Joao-Dionisio merged 6 commits intomasterfrom
interface-solveProbingLPWithPricing
May 9, 2026
Merged

Interface solveProbingLPWithPricing()#1215
Joao-Dionisio merged 6 commits intomasterfrom
interface-solveProbingLPWithPricing

Conversation

@Joao-Dionisio
Copy link
Copy Markdown
Member

@marouane-f can you please review? (😡 😡 😡 😡 😡 😡 )

@Joao-Dionisio Joao-Dionisio requested a review from Copilot May 8, 2026 17:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new PySCIPOpt Model.solveProbingLPWithPricing() wrapper (Cython + stub) and a regression test to exercise it from a branching callback, documenting the addition in the changelog.

Changes:

  • Wrapped SCIPsolveProbingLPWithPricing() in Model.solveProbingLPWithPricing() and exposed it via the Cython interface.
  • Added a test branchrule that enters probing mode, constructs the LP, and calls the new API.
  • Documented the new API in CHANGELOG.md and added the signature to scip.pyi.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/test_branch_probing_lp.py Adds a new test branchrule and test case that calls solveProbingLPWithPricing() during probing.
src/pyscipopt/scip.pyi Adds the Model.solveProbingLPWithPricing() stub signature.
src/pyscipopt/scip.pxi Implements Model.solveProbingLPWithPricing() calling SCIPsolveProbingLPWithPricing.
src/pyscipopt/scip.pxd Declares the SCIPsolveProbingLPWithPricing C API symbol.
CHANGELOG.md Notes the new wrapper and test in the “Added” section.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_branch_probing_lp.py
@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 57.45%. Comparing base (3f581ef) to head (d39f3e9).

Files with missing lines Patch % Lines
src/pyscipopt/scip.pxi 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1215   +/-   ##
=======================================
  Coverage   57.44%   57.45%           
=======================================
  Files          26       26           
  Lines        5725     5728    +3     
=======================================
+ Hits         3289     3291    +2     
- Misses       2436     2437    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Joao-Dionisio
Copy link
Copy Markdown
Member Author

Will merge because I want to get the release out of the way this weekend.

@Joao-Dionisio Joao-Dionisio merged commit 9a161ce into master May 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants