Interface solveProbingLPWithPricing()#1215
Merged
Joao-Dionisio merged 6 commits intomasterfrom May 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new PySCIPOpt Model.solveProbingLPWithPricing() wrapper (Cython + stub) and a regression test to exercise it from a branching callback, documenting the addition in the changelog.
Changes:
- Wrapped
SCIPsolveProbingLPWithPricing()inModel.solveProbingLPWithPricing()and exposed it via the Cython interface. - Added a test branchrule that enters probing mode, constructs the LP, and calls the new API.
- Documented the new API in
CHANGELOG.mdand added the signature toscip.pyi.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_branch_probing_lp.py | Adds a new test branchrule and test case that calls solveProbingLPWithPricing() during probing. |
| src/pyscipopt/scip.pyi | Adds the Model.solveProbingLPWithPricing() stub signature. |
| src/pyscipopt/scip.pxi | Implements Model.solveProbingLPWithPricing() calling SCIPsolveProbingLPWithPricing. |
| src/pyscipopt/scip.pxd | Declares the SCIPsolveProbingLPWithPricing C API symbol. |
| CHANGELOG.md | Notes the new wrapper and test in the “Added” section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1215 +/- ##
=======================================
Coverage 57.44% 57.45%
=======================================
Files 26 26
Lines 5725 5728 +3
=======================================
+ Hits 3289 3291 +2
- Misses 2436 2437 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Will merge because I want to get the release out of the way this weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@marouane-f can you please review? (😡 😡 😡 😡 😡 😡 )