Fix vcfstats.c on big-endian platforms#2569
Merged
Merged
Conversation
Use htslib/hts_endian.h functions to avoid problems with unaligned access, and to ensure numbers are byteswapped on platforms that need it. Signed-off-by: John Marshall <jmarshall@hey.com>
Member
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Byteswap as appropriate. As mentioned in PR #2044, this may avoid problems with unaligned access on little-endian platforms too.
After application of this PR, bcftools's tests pass on s390x.
Note that there still exist numerous
#define BRANCH…macros that do not have aconvertparameter. These presumably represent functionality that is not big-endian-correct but which is not exercised by the test suite.