Repository navigation
Conversation
This mixin adjusts the wireless modem range calculations to account for sub-level distances by injecting into the tryTransmit method.
Collaborator
|
This is awful, inject + unconditional cancels should never be used. |
Collaborator
|
Furthermore this fix is entirely incorrect, |
Author
|
Thanks, I went more in depth into the issue it was caused by a code injection incompatibility between Valkyrien skies and Sable ended up creating my own patch/bridge and it now works with both mods at the same time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixes an
InjectionError(Scanned 0 target(s)) occurring when running Sable alongside CC: Tweaked 1.120.0+.Problem
The previous implementation relied on a
@Redirecttargeting theVec3.distanceToSqrinvocation insideWirelessNetwork.tryTransmit. Bytecode shifts or instruction changes in recent CC: Tweaked builds caused Mixin to fail locating the targeted instruction, resulting in a server crash on startup.Solution
Replaced the fragile
@Redirectwith a head injection (@At("HEAD")) ontryTransmit(PacketReceiver, Packet, double, boolean):tryTransmitat entry.Sable.HELPER.distanceSquaredWithSubLevels(...).ci.cancel().This approach avoids fragile
INVOKEmatching while maintaining full sub-level distance support for wireless modems.