Skip unsupported _CRS resource descriptors - #316
Conversation
8336415 to
12d461e
Compare
Hi, yes I needed both in a firmware project and forgot to change the base of this one. I'm looking forward to GitHub stacked pr feature https://github.github.com/gh-stack/ that would make this easier :-) |
|
Ooh - I like the looks of that! So long as I can restrain myself from creating a giant queue of PRs in stack format... In terms of 12d461e, I think this looks good. As with #317, thanks for adding a quick test. I guess ideally there'd be a matching small descriptor test, but personally I'd be happy to merge without it. (once #317 is in) |
Allow DerefOf to read directly from BufferField objects. This matches AML patterns emitted by firmware that creates named fields over buffers and then uses DerefOf(field).
Skip unsupported _CRS resource descriptors instead of panicking. Callers can still consume the MMIO/IRQ descriptors they understand from mixed resource buffers containing GPIO or GenericSerialBus descriptors.
12d461e to
ea22222
Compare
|
I added a test for unsupported small resource descriptor. Thanks for the suggestion. |
|
Nice, thanks for the PR! It should definitely be possible to rebase onto another base branch, but this is fine. |
3 participants
Skip unsupported _CRS resource descriptors instead of panicking. Callers can still consume the MMIO/IRQ descriptors they understand from mixed resource buffers containing GPIO or GenericSerialBus descriptors.