Add Earth Mover's Distance to linfa-nn#440
Open
mrsanor wants to merge 1 commit into
Open
Conversation
mrsanor
changed the title
relf
reviewed
May 13, 2026
| assert_abs_diff_eq!(ab, 0.9, epsilon = 1e-5); | ||
|
|
||
| let a = arr1(&[0.35, 0.15, 0.15, 0.10, 0.25]); | ||
| let b = arr1(&[0.1, 0.20, 0.05, 0.20, 0.45]); |
Member
There was a problem hiding this comment.
Slight variations in input data, maybe add a comment to explain what we should see as a result. You can also test against scipy examples
relf
reviewed
May 13, 2026
| let a = arr2(&[[0.3, 0.2, 0.15, 0.10, 0.25], [0.35, 0.15, 0.15, 0.10, 0.25]]); | ||
| let b = arr2(&[[0.1, 0.2, 0.05, 0.20, 0.45], [0.1, 0.20, 0.05, 0.20, 0.45]]); | ||
| let ab = dist.distance(a.view(), b.view()); | ||
| assert_abs_diff_eq!(ab, 0.9 + 0.95, epsilon = 1e-5); |
Member
There was a problem hiding this comment.
You could use previous a, b, ab variables
relf
requested changes
May 13, 2026
| serde(crate = "serde_crate") | ||
| )] | ||
| #[derive(Debug, Clone, PartialEq, Eq)] | ||
| pub struct EarthMoverDist; |
Member
There was a problem hiding this comment.
I would go with WassersteinDist as you put it first above and it will be consistent with scipy impl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Earth Mover's Distance, aka. Wasserstein to linfa-nn