Add clippy linting to all packages - #7116
Merged
ytmimi merged 1 commit intoSep 15, 2026
Merged
Conversation
rustbot
added
A-CI
matthewhughes934
force-pushed
the
add-clippy-repeated-config
branch
3 times, most recently
from
September 12, 2026 15:19
1f797ab to
b8e813a
Compare
Contributor
|
Might want to add a section to the contributing docs that explains how to run clippy before submitting PRs. |
matthewhughes934
force-pushed
the
add-clippy-repeated-config
branch
from
September 14, 2026 17:03
b8e813a to
1e9c7d6
Compare
Contributor
Author
👍 done |
matthewhughes934
force-pushed
the
add-clippy-repeated-config
branch
from
September 14, 2026 18:52
1e9c7d6 to
3f9f3fd
Compare
ytmimi
reviewed
Sep 14, 2026
| $ cargo clippy --manifest-path ./config_proc_macro/Config.toml | ||
| # or run the command from within the package | ||
| $ cd ./config_proc_macro | ||
| $ cargo clippy |
Contributor
There was a problem hiding this comment.
Lets use code fences for code examples. Let's also removing leading $ since they'll get included when users copy and paste the input, which is a little paper cut that can be a bit annoying to remove.
Contributor
Author
There was a problem hiding this comment.
Lets use code fences for code examples. Let's also removing leading
$since they'll get included when users copy and paste the input, which is a little paper cut that can be a bit annoying to remove.
Updated: 05840bc
matthewhughes934
marked this pull request as ready for review
September 15, 2026 18:22
rustbot
added
S-waiting-on-review
Duplicate the same config across each package and add a script that verifies these configs are all equal, and add a workflow so that `clippy` is run across all packages in PRs.
matthewhughes934
force-pushed
the
add-clippy-repeated-config
branch
from
September 15, 2026 18:24
3f9f3fd to
05840bc
Compare
ytmimi
approved these changes
Sep 15, 2026
rustbot
added
release-notes
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duplicate the same config across each package and add a script that verifies these configs are all equal, and add a workflow so that
clippyis run across all packages in PRs.Compare with: #7117 this change has
cargo clippyin any package, which works nicely with common workflows like IDE integrations