Rollup of 7 pull requests - #162664
Merged
Merged
Conversation
* Clarify examples related to `Sync` and `SyncView` Updated examples to clarify the role of non-`Sync` fields and the functionality of `SyncView`. * Apply suggestion from @tisonkun * Update library/core/src/sync/sync_view.rs Co-authored-by: Laine Taffin Altman <alexanderaltman@me.com>
We have Rust Compiler Development Guide for that.
I've not paid much attention to it in recent times
…r=saethlin mir-transform: Remove `is_optimization_stage` Based on rust-lang#160524 until that one is merged rust-lang#160524 (comment)
Re-export `core::fmt::NumBuffer` in `alloc` (and `std`) We just stabilized `core::fmt::NumBuffer` in Rust 1.98, but it seems to be a simple oversight that this was not also re-exported in `alloc::fmt` (and `std` just re-exports that whole module). Let's correct that. I'm marking this stable right away, although I don't think the later `since` version will be properly rendered in docs for a re-export. I'm not sure it's worth trying to clarify that in freeform documentation.
…ail, r=jieyouxu Prevent `should-fail` to be used in `rustdoc-ui` testsuite Follow-up of rust-lang#162030 and discussion with @fmease. There is no reason to use `should-fail` for `rustdoc-ui` (or `rustdoc-html`) testsuite, so let's prevent it. r? @fmease
Clarify examples related to `Sync` and `SyncView` Updated examples to clarify the role of non-`Sync` fields and the functionality of `SyncView`. This refers to rust-lang#98407
Initialize mingw for all mingw targets Fixes rust-lang#162594
… r=jieyouxu Remove needless test running instructions We have Rust Compiler Development Guide for that. r? @jieyouxu
…atrieb Remove noras target docs mention I've not paid much attention to it in recent times
rustbot
added
A-CI
Member
Author
|
@bors r+ p=5 |
Contributor
rust-bors
Bot
added
the
S-waiting-on-bors
rust-bors
Bot
removed
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 3fbb92e (parent) -> 0fc1413 (this PR) Test differencesShow 16 test diffs16 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0fc141305da7a8a222f65aef1f1acc739c46282b --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (0fc1413): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.3%, secondary 1.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.1%, secondary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 492.981s -> 492.706s (-0.06%) |
Contributor
|
📌 Perf builds for each rolled up PR:
parent commit: 3fbb92e141 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
is_optimization_stage#161413 (mir-transform: Removeis_optimization_stage)core::fmt::NumBufferinalloc(andstd) #161430 (Re-exportcore::fmt::NumBufferinalloc(andstd))should-failto be used inrustdoc-uitestsuite #162446 (Preventshould-failto be used inrustdoc-uitestsuite)SyncandSyncView#162621 (Clarify examples related toSyncandSyncView)r? @ghost
Create a similar rollup