move bug and span_bug macros to rustc_span by mejrs · Pull Request #161873 · rust-lang/rust

mejrs · 2026-08-27T14:26:44Z

This allows them to be used without depending on rustc_middle.

This is done by using a rustc_interface callback so that, if the callback is set, a internal compiler error diagnostic is printed through that. After that the panic is initiated.

r? @jdonszelmann @bjorn3

rustbot · 2026-08-27T14:26:49Z

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

changes to the core type system

cc @lcnr

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred to constck

cc @fee1-dead

Some changes occurred in coverage instrumentation.

cc @Zalathar

changes to the core type system

cc @lcnr

Some changes occurred in compiler/rustc_codegen_llvm/src/llvm/enzyme_ffi.rs

cc @ZuseZ4

Some changes occurred in compiler/rustc_codegen_llvm/src/builder/autodiff.rs

cc @ZuseZ4

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

Some changes occurred in match checking

cc @Nadrieril

Some changes occurred in match lowering

cc @Nadrieril

rustc_codegen_gcc is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_gcc instead.

cc @antoyo, @GuillaumeGomez

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

HIR ty lowering was modified

cc @fmease

rustbot · 2026-08-27T14:26:52Z

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

GuillaumeGomez · 2026-08-27T14:27:46Z

Neat. :)

@bjorn3

Mark `extern_item_impls` feature as incomplete context: rust-lang#161873 (comment) > If they are so unstable, maybe they should have a separate feature gate that's marked as `incomplete`. Or the entire `extern_item_impls` should be marked "incomplete". I think it's just best to mark the entire thing as incomplete for now. Later, when the implementation matures we can consider removing the incompleteness or splitting the feature in unstable and incomplete parts. r? @bjorn3 @RalfJung

@bjorn3

Mark `extern_item_impls` feature as incomplete context: rust-lang#161873 (comment) > If they are so unstable, maybe they should have a separate feature gate that's marked as `incomplete`. Or the entire `extern_item_impls` should be marked "incomplete". I think it's just best to mark the entire thing as incomplete for now. Later, when the implementation matures we can consider removing the incompleteness or splitting the feature in unstable and incomplete parts. r? @bjorn3 @RalfJung

@bjorn3

Mark `extern_item_impls` feature as incomplete context: rust-lang#161873 (comment) > If they are so unstable, maybe they should have a separate feature gate that's marked as `incomplete`. Or the entire `extern_item_impls` should be marked "incomplete". I think it's just best to mark the entire thing as incomplete for now. Later, when the implementation matures we can consider removing the incompleteness or splitting the feature in unstable and incomplete parts. r? @bjorn3 @RalfJung

@bjorn3

Rollup merge of #161891 - mejrs:eii_incomplete, r=RalfJung Mark `extern_item_impls` feature as incomplete context: #161873 (comment) > If they are so unstable, maybe they should have a separate feature gate that's marked as `incomplete`. Or the entire `extern_item_impls` should be marked "incomplete". I think it's just best to mark the entire thing as incomplete for now. Later, when the implementation matures we can consider removing the incompleteness or splitting the feature in unstable and incomplete parts. r? @bjorn3 @RalfJung

rustbot · 2026-08-28T22:31:21Z

rustc_errors::annotate_snippet_emitter_writer was changed

cc @Muscraft

rustbot · 2026-08-28T22:38:05Z

rustc_codegen_cranelift is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_cranelift instead.

cc @bjorn3

rustbot · 2026-09-15T14:20:32Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

mejrs · 2026-09-15T15:28:24Z

@bors r=tiif

rust-bors · 2026-09-15T15:28:28Z

📌 Commit 86052b2 has been approved by tiif

It is now in the queue for this repository.

rust-bors · 2026-09-15T16:00:34Z

⚠️ A new commit 65ae042ecc466e238cc338d5432095aefdbfe3a9 was pushed.

This pull request was unapproved.

mejrs · 2026-09-15T17:54:54Z

@bors r=tiif

rust-bors · 2026-09-15T17:54:57Z

📌 Commit 575aae6 has been approved by tiif

It is now in the queue for this repository.

…uwer Rollup of 7 pull requests Successful merges: - #161873 (move bug and span_bug macros to rustc_span) - #162584 (Use File::*lock*() in rustc_data_structures::flock when possible) - #162704 (Parser: Uninterpolate when checking for const closures, try bikeshed blocks & in relevant diagnostic code) - #162787 (Fix suggestions for names captured by formatting macros) - #159562 (Windows: cache the stdio write mode for the duration of a lock session) - #162813 (Pre lint port cleanups) - #162822 (PassWrapper: adapt for removal of EABIVersion arg in LLVM 24)

@jdonszelmann

Rollup merge of #161873 - mejrs:bug, r=tiif move bug and span_bug macros to rustc_span This allows them to be used without depending on rustc_middle. This is done by using a rustc_interface callback so that, if the callback is set, a internal compiler error diagnostic is printed through that. After that the panic is initiated. r? @jdonszelmann @bjorn3

PR rust-lang#161873 moved these macros from `rustc_middle` to `rustc_span`. In doing so it made some undesirable changes. - The internal `emit_producing_nothing` became public. - The macros now have different behaviour to function-based ICEs like `dcx.bug(..)` or `dcx.struct_bug(..).emit()`. This commit reverts those changes. This brings back `Box<dyn Any>` output in a few tests because the panic payload is `ExplicitBug` (which std doesn't know about) rather than `String`. That might be worth fixing again in the future, but if so, it should be done in a way that works with all aborts, not just those done via the macros.

…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#161873 (move bug and span_bug macros to rustc_span) - rust-lang/rust#162584 (Use File::*lock*() in rustc_data_structures::flock when possible) - rust-lang/rust#162704 (Parser: Uninterpolate when checking for const closures, try bikeshed blocks & in relevant diagnostic code) - rust-lang/rust#162787 (Fix suggestions for names captured by formatting macros) - rust-lang/rust#159562 (Windows: cache the stdio write mode for the duration of a lock session) - rust-lang/rust#162813 (Pre lint port cleanups) - rust-lang/rust#162822 (PassWrapper: adapt for removal of EABIVersion arg in LLVM 24)

PR rust-lang#161873 moved these macros from `rustc_middle` to `rustc_span`. In doing so it made some undesirable changes. - The internal `emit_producing_nothing` became public. - It gave the macros different behaviour to function-based ICEs like `dcx.bug(..)` or `dcx.struct_bug(..).emit()`. - `ExplicitBug` is not used, so `report_ice` prints an extraneous, unintended "the compiler unexpectedly panicked" message. - It broke the interaction between `span_bug!` and `-Ztrack-diagnostics`. This commit adjusts things to avoid the undesirable changes. It required moving `ExplicitBug` to `rustc_span`. Setting `diag.emitted_at` fixed the `-Ztrack-diagnostics` problem, seen in the change from `callback.rs` to `validate.rs` in `track7.stderr`. `Box<dyn Any>` output now occurs again in a few tests because the panic payload is `ExplicitBug` (which std doesn't know about) rather than `String`. That might be worth addressing in the future but it would require a different/additional mechanism and is beyond the scope of this PR.

rustbot added the A-attributes Area: Attributes (`#[…]`, `#![…]`) label Aug 27, 2026

rustbot assigned jdonszelmann Aug 27, 2026

mejrs force-pushed the bug branch from d343ad6 to 7ff2483 Compare August 27, 2026 14:30

This comment has been minimized.

Sign in to view

bjorn3 reviewed Aug 27, 2026

View reviewed changes

Comment thread compiler/rustc_span/src/macros.rs Outdated

bjorn3 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2026

mejrs mentioned this pull request Aug 27, 2026

Mark extern_item_impls feature as incomplete #161891

Merged

This comment has been minimized.

Sign in to view

mejrs force-pushed the bug branch 2 times, most recently from 2b61a0e to aed9a77 Compare August 28, 2026 22:31

mejrs force-pushed the bug branch from aed9a77 to 141fafc Compare August 28, 2026 22:38

This comment has been minimized.

Sign in to view

mejrs changed the title ~~use eii for bug! macro~~ move bug and span_bug macros to rustc_span Aug 28, 2026

This comment has been minimized.

Sign in to view

mejrs added 5 commits September 15, 2026 16:20

use span_bug in Ident::new

7cf2239

compiler: fix bug and span_bug imports

6aaabbb

Fix tools

d2e8729

fix tests

a8baa0b

fix miri tests

65ae042

mejrs force-pushed the bug branch from 0f31e95 to 86052b2 Compare September 15, 2026 14:20

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 15, 2026

mejrs force-pushed the bug branch from 86052b2 to 65ae042 Compare September 15, 2026 16:00

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 15, 2026

fix span_delayed_bug doc links

575aae6

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 15, 2026

JonathanBrouwer mentioned this pull request Sep 15, 2026

Rollup of 7 pull requests #162827

Merged

rust-bors Bot merged commit a6a5468 into rust-lang:main Sep 16, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Sep 16, 2026

nnethercote mentioned this pull request Sep 16, 2026

Adjust bug!/span_bug! emission #162873

Open

Uh oh!

Conversation

mejrs commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 27, 2026

Uh oh!

rustbot commented Aug 27, 2026

Uh oh!

GuillaumeGomez commented Aug 27, 2026

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

rustbot commented Aug 28, 2026

Uh oh!

rustbot commented Aug 28, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Sep 15, 2026

Uh oh!

mejrs commented Sep 15, 2026

Uh oh!

rust-bors Bot commented Sep 15, 2026

Uh oh!

rust-bors Bot commented Sep 15, 2026

Uh oh!

mejrs commented Sep 15, 2026

Uh oh!

rust-bors Bot commented Sep 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

mejrs commented Aug 27, 2026 •

edited

Loading