feat: Update method signature of int_from_ascii#159554
Open
ajtribick wants to merge 1 commit into
Open
Conversation
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
ajtribick
force-pushed
the
int_from_ascii_bytes
branch
from
July 19, 2026 08:48
1e6c9d4 to
3d1d65a
Compare
This comment has been minimized.
This comment has been minimized.
ajtribick
force-pushed
the
int_from_ascii_bytes
branch
from
July 19, 2026 09:22
3d1d65a to
0bd28ea
Compare
7 tasks
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
@niklasf thanks for pointing this out, fixed the typo :) |
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
Also fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
int_from_ascii#134821Following discussion on Zulip it appears the preference is to change the API for this feature as follows:
and similarly for
NonZero<X>.Reasons behind the change:
ByteStr/ByteStringtypes: Tracking Issue for ByteStr/ByteString #134915This pull request applies this change. The const-ness of these functions is now feature gated behind #143773