Use EII for #[panic_handler]#159016
Draft
bjorn3 wants to merge 7 commits into
Draft
Conversation
rustbot
added
A-attributes
Member
Author
80 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The only way it was possible to skip needing to declare #[panic_handler] is using #![no_core], which is unstable anyway. Always requiring \#[panic_handler] makes things more consistent and avoids having to special case several MIR optimizations for the absence of #[panic_handler].
bjorn3
force-pushed
the
eii_panic_handler
branch
from
July 24, 2026 09:48
ecd1f4c to
2f001d2
Compare
bjorn3
commented
Jul 24, 2026
|
|
||
| /// Attribute macro applied to a function to register it as a panic handler. | ||
| /// | ||
| /// See also [`core::panic::PanicInfo`](crate::panic::PanicInfo). |
Member
Author
There was a problem hiding this comment.
There are probably better pages to link to.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot)Important For more information how to resolve CI failures of this job, visit this link. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While we can't yet use EIIs for things like the global allocator due to missing platform support, we can safely use it for #[panic_handler] as that doesn't require any object file format features. Just matching symbol names.
This gets rid of one of the two remaining weak lang items.
TODO
#[target_feature]on the panic handler.