Support move expressions in coroutine closures

[TaKO8Ki]

This adds move(expr) support for coroutine closures.

• Support for move expressions in coroutine closures
• Support for move expressions in async blocks

RFC: rust-lang/rfcs#3968
Tracking issue: #155050
Project goal:

• Ergonomic ref-counting rust-project-goals#107
• https://rust-lang.github.io/rust-project-goals/2026/ergonomic-rc.html

r? @nikomatsakis

[rustbot]

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

[rustbot]

nikomatsakis is currently at their maximum review capacity.
They may take a while to respond.

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[nikomatsakis]

Hmm. Something seems off here. I think we need more tests around nested-move and async blocks, async closures, and gen blocks. For example I'd expect:

let c: Arc<String> = Default::default();
let future = async {
    let f = async {
        move(c.clone());
    };
    assert!( /* c ref count is 2 */ );
    f.await;
    assert!( /* c ref count is 1 */ );
    drop(c);
};

let c: Arc<String> = Default::default();
let future = async {
    let f = async {
        move(c.clone());
    };
    f.await;
    drop(c);
};
println!("{c}"); // <-- ERROR: c is moved

let c: Arc<String> = Default::default();
let future = async {
    let f = async {
        move(move(c.clone()));
    };
    assert!( /* c ref count is 3 */ );
    f.await;
    assert!( /* c ref count is 2 */ );
    drop(c);
};
println!("{c}"); // OK, prints ""

View changes since this review

[nikomatsakis]

Huh, this is somewhat surprising to me. I expected an error for this example.

Is this an artifact of the desugaring?