Skip to content

chore: fix lint cargo::manual_readme - #17634

Merged
rustbot merged 1 commit into
rust-lang:masterfrom
weihanglo:cargo-lints
Aug 27, 2026
Merged

chore: fix lint cargo::manual_readme#17634
rustbot merged 1 commit into
rust-lang:masterfrom
weihanglo:cargo-lints

Conversation

@weihanglo

Copy link
Copy Markdown
Member

@rustbot rustbot added the S-waiting-on-community-reviews Status: This is awaiting for positive reviews from the community before a maintainer is assigned. label Aug 27, 2026
@rustbot

rustbot commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews.

In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 27, 2026
@weihanglo

weihanglo commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

clippy::cargo-common-metadata lint's behavior conflicts with the new cargo::manual_readme.

 FAILED TEST: tests/ui-cargo/cargo_common_metadata/pass/Cargo.toml
command: CARGO_INCREMENTAL="0" RUSTC_ICE="0" RUSTFLAGS="-Dwarnings -Znext-solver=coherence" "/home/runner/work/rust-clippy/rust-clippy/target/debug/cargo-clippy" "clippy" "--color" "never" "--quiet" "--target-dir" "/home/runner/work/rust-clippy/rust-clippy/target/ui_test/0/tests/ui-cargo/cargo_common_metadata/pass" "--manifest-path" "tests/ui-cargo/cargo_common_metadata/pass/Cargo.toml"

error: no output was expected
Execute `cargo uibless` to update `tests/ui-cargo/cargo_common_metadata/pass/Cargo.stderr` to the actual output
+++ <stderr output>
error: package `cargo_common_metadata_pass` is missing `package.readme` metadata
  |
  = note: `-D clippy::cargo-common-metadata` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(clippy::cargo_common_metadata)]`

error: could not compile `cargo_common_metadata_pass` (bin "cargo_common_metadata_pass") due to 1 previous error


full stderr:
error: package `cargo_common_metadata_pass` is missing `package.readme` metadata
  |
  = note: `-D clippy::cargo-common-metadata` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(clippy::cargo_common_metadata)]`

To make test pass for now, let just don't deal with clippy::cargo_common_metadata and its tests.

@weihanglo weihanglo closed this Aug 27, 2026
@weihanglo
weihanglo deleted the cargo-lints branch August 27, 2026 00:40
@rustbot rustbot removed S-waiting-on-community-reviews Status: This is awaiting for positive reviews from the community before a maintainer is assigned. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Aug 27, 2026
@weihanglo
weihanglo restored the cargo-lints branch August 27, 2026 00:40
@weihanglo weihanglo reopened this Aug 27, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 27, 2026

@CommanderStorm CommanderStorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Community review: lgtm

View changes since this review

@Jarcho

Jarcho commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Looks like re-opening this broke the community review feature. cc @Urgau

@rustbot merge

@rustbot
rustbot added this pull request to the merge queue Aug 27, 2026
@weihanglo

Copy link
Copy Markdown
Member Author

Looks like re-opening this broke the community review feature.

I am sorry for that 😰.

Merged via the queue into rust-lang:master with commit 7b735b8 Aug 27, 2026
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 27, 2026
@weihanglo
weihanglo deleted the cargo-lints branch August 27, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants