Reduce the amount of code in unsafe blocks#1271
Merged
Merged
Conversation
weihanglo
approved these changes
Jun 10, 2026
Comment on lines
+388
to
+397
| let to; | ||
| let from; | ||
| let mode; | ||
| unsafe { | ||
| try_call!(raw::git_revparse(&mut raw, self.raw, spec)); | ||
| let to = Binding::from_raw_opt(raw.to); | ||
| let from = Binding::from_raw_opt(raw.from); | ||
| let mode = RevparseMode::from_bits_truncate(raw.flags as u32); | ||
| Ok(Revspec::from_objects(from, to, mode)) | ||
| to = Binding::from_raw_opt(raw.to); | ||
| from = Binding::from_raw_opt(raw.from); | ||
| mode = RevparseMode::from_bits_truncate(raw.flags as u32); | ||
| } | ||
| Ok(Revspec::from_objects(from, to, mode)) |
Member
There was a problem hiding this comment.
I got it, though this seems to be less ideal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For statements that do not need to be marked as unsafe, pull them out of the blocks