fix(spam): Now only submit Spam/Not spam once (2x confuses the backend) - #2004
Open
castaway wants to merge 1 commit into
Open
fix(spam): Now only submit Spam/Not spam once (2x confuses the backend)#2004castaway wants to merge 1 commit into
castaway wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report from users that they get an error when marking several messages as "not spam". Due to the way RXJS was being used, we were POSTing twice to the spam endpoint. This sometimes caused the "check for entry in whitelist, if not then insert" code to check twice, then try and insert twice - the 2nd insert would fail as the first had already succeeded.
Fix also included that caused many other endpoints to be called twice.