Add a configurable "mark" flag to taggings and subscriptions - #2478
Merged
Conversation
maebeale
force-pushed
the
maebeale/add-flagged-boolean
branch
from
September 1, 2026 16:38
ea898b4 to
788b128
Compare
maebeale
marked this pull request as ready for review
September 1, 2026 17:04
Each staff tag and topic names its own checkbox (mark_label — "Confirmed", "Completed", etc.); each tagging/subscription carries the boolean. Meaning lives in the per-tag/topic label so it can be anything, while the storage stays generic. Adds a sortable mark column and an All/Yes/No filter to both indexes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…link - New and edit staff-tagging forms carry a mark slider captioned with the selected tag's mark label, revealed once a tag is chosen (mark_toggle Stimulus controller reads the option's data-mark-label). Create now persists it. - The Mark column header on both indexes shows the filtered tag/topic's mark label when the list is narrowed to a single one. - Staff taggings index gains a "Staff tags" nav link, left of Topic subscriptions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…n a filter card - Drop the one-off Stimulus controller; the mark toggle now reuses the existing peer-checked slider style (as certificate-issued does). Caption is server- rendered: the tag's mark label on edit, the generic default on new. - Staff taggings filters move into a gray filter card with the shared filter-icon header; subscriptions filter card gains the same header for parity. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Inline mark slider per row toggles `marked` via Turbo (toggle_marked action + turbo_stream replacing just the cell) — same no-JS pattern as certificate-issued. - Per-row notes box autosaves on blur through the existing `autosave` controller to a save_note action that upserts the row's latest comment (shows in its log). - Both index tables gain a Notes column; comments eager-loaded to avoid N+1. - Drop the now-unused marked_indicator helper. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/add-flagged-boolean
branch
from
September 1, 2026 17:46
dd3fd8d to
93b6839
Compare
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…Comments Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 additive columns + inline Turbo actions across two index flows; reuses existing JS
Lets staff tag people and then check them off the list — marking a topic subscription or a staff tagging right on the index, with a per-row notes box. The mark means whatever each topic/tag decides ("Confirmed", "Completed", "Tracked", …).
How it works
mark_label— the word for its mark (editable on Manage staff tags / Manage topics). Defaults to "Marked".markedboolean.On the index (the main workflow)
markedin place via Turbo (toggle_marked→ turbo_stream replacing just the cell) — the same no-JS pattern as certificate-issued.autosaveStimulus controller (no new JS) to asave_noteaction, which upserts the row's latest comment — so it shows up in that row's comment log.Setting the mark elsewhere
Notes for the reviewer
_top.markeddefault false + index;mark_labelnullable) — no backfill.🤖 Generated with Claude Code