Fix unused variable warning in generated markdown parser#1708
Merged
Conversation
tompng
temporarily deployed
to
fork-preview-protection
GitHub Actions
Inactive
st0012
approved these changes
May 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an unused-local-variable warning emitted by the generated Markdown parser by updating the StrippedComment grammar rule to stop capturing matched text that is never referenced.
Changes:
- Updated
StrippedCommentrule to remove the< ... >text-capture wrapper while keeping the same match behavior. - Regenerated/updated the corresponding Ruby parser method to eliminate the now-unneeded
_text_start/textassignments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/rdoc/markdown.kpeg | Updates the StrippedComment grammar rule to avoid capturing unused text. |
| lib/rdoc/markdown.rb | Reflects the grammar change in the generated parser code and rule metadata, removing the unused variable assignment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
🚀 Preview deployment available at: https://833b4136.rdoc-6cd.pages.dev (commit: 003c83e) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.