refactor(fmt): reuse relative path resolver - #208
Merged
Conversation
Deploying rstack-cli with
|
| Latest commit: |
015bbd7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://50acb937.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-refactor-fmt-rela.rstack-cli.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed-root relative path handling is duplicated across discovery,
GitIgnoreMatcher, and formatter ignore matching. This PR extracts a shared resolver and reuses it in all three locations, while also reusing the resolved GitIgnore path for its root-boundary check.On rsbuild, discovery
path.relativecalls drop from 12 to 2 for the default scan, from 11 to 1 for a positive glob, and from 12 to 2 for a negative glob. Focused tests cover root, descendant, and outside-root paths.