Skip to content

Change constructor overloads to sidestep uncrustify differences (backport #949) - #950

Merged
jmachowinski merged 1 commit into
lyricalfrom
mergify/bp/lyrical/pr-949
Jul 14, 2026
Merged

Change constructor overloads to sidestep uncrustify differences (backport #949)#950
jmachowinski merged 1 commit into
lyricalfrom
mergify/bp/lyrical/pr-949

Conversation

@mergify

@mergify mergify Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Description

This PR resolves the uncrustify failures on RHEL 10 for both StaticTransformBroadcaster and TransformBroadcaster.

Fixes #941

Is this user-facing behavior change?

Did you use Generative AI?

Yes, this pull request was prepared and verified with the assistance of Gemini CLI.

Assisted-by: Gemini CLI:Gemini 3.5 Flash [list_dir, list_permissions, run_command, view_file, grep_search, replace_file_content,
read_url_content]

Additional Information


This is an automatic backport of pull request #949 done by [Mergify](https://mergify.com).

Fixes: #941

Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com>
(cherry picked from commit 18314a0)
@jmachowinski

jmachowinski commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Pulls: #950
Gist: https://gist.githubusercontent.com/jmachowinski/7b33e2d8426626ecb10c27e91ddb3084/raw/09d5419a2afd9a8bb04498376cb12f7789e0f9ce/ros2.repos
BUILD args:
TEST args:
ROS Distro: lyrical
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19486

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@mergify

mergify Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@jmachowinski

Copy link
Copy Markdown
Contributor

Windows CI is actually unstable even though it says failure

@jmachowinski
jmachowinski merged commit b6f76c7 into lyrical Jul 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants