[6.40] [tmva][sofie] Use double for accumulator in numeric differentiation result#22793
Merged
guitargeek merged 1 commit intoJul 13, 2026
Conversation
Use `double` for the accumulator in the computation of the numerically differentiated reference result. This should fix the platform-dependent test failure that we are seeing see only on Fedora 44 (master and 6.40): ```txt 1359/3779 Test root-project#474: tmva-sofie-test-TestCladAutodiff ..................................................................***Failed 1.72 sec -- TEST COMMAND -- cd /github/home/ROOT-CI/build/tmva/sofie/test ./TestCladAutodiff -- BEGIN TEST OUTPUT -- Running main() from /builddir/build/BUILD/gtest-1.17.0-build/googletest-1.17.0/googletest/src/gtest_main.cc [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from ONNXClad [ RUN ] ONNXClad.Linear16 /github/home/ROOT-CI/src/tmva/sofie/test/TestCladAutodiff.cxx:109: Failure Failed Mismatch at index 1233 analytic=0.02939869649708271 numeric=0.026702878996729851 diff=0.0026958175003528595 [ FAILED ] ONNXClad.Linear16 (1637 ms) [----------] 1 test from ONNXClad (1637 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (1642 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] ONNXClad.Linear16 1 FAILED TEST -- END TEST OUTPUT -- CMake Error at /github/home/ROOT-CI/src/cmake/modules/RootTestDriver.cmake:210 (message): got exit code 1 but expected 0 ``` (cherry picked from commit 7cf1115)
guitargeek
changed the title
double\ for accumulator in numeric differentiation resultdouble for accumulator in numeric differentiation result
guitargeek
merged commit d59ef15
into
root-project:v6-40-00-patches
33 of 34 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #22789, requested by @guitargeek.