[ntuple] implement nested SoA I/O#22761
Open
jblomer wants to merge 4 commits into
Open
Conversation
jblomer
force-pushed
the
ntuple-soa-nested
branch
from
3dc3b51 to
6ca7c23
Compare
Test Results 23 files 23 suites 3d 17h 0m 39s ⏱️ Results for commit 41df590. ♻️ This comment has been updated with latest results. |
hahnjo
approved these changes
Jul 13, 2026
hahnjo
left a comment
hahnjo
left a comment
Member
There was a problem hiding this comment.
LGTM, with some minor comments in the support for inheritance
Allow for SoA types that spell out the RVecs of sub struct members of the underlying record type.
jblomer
force-pushed
the
ntuple-soa-nested
branch
from
6ca7c23 to
41df590
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for using SoA types inside SoA types, including SoA types inheriting from SoA types.
As a result, users can decide on each nesting level if they want to roll out the nested SoA layout (class member is a SoA type) or represent the nested struct as an AoS (
RVec<underlying record type>).Belongs to issue #19230